From: Greg KH <gregkh@linuxfoundation.org>
To: Vincenzo Mezzela <vincenzo.mezzela@gmail.com>
Cc: johannes@sipsolutions.net, sashal@kernel.org,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
javier.carrasco.cruz@gmail.com, skhan@linuxfoundation.org,
stable@vger.kernel.org, Johannes Berg <johannes.berg@intel.com>,
syzbot+07bee335584b04e7c2f8@syzkaller.appspotmail.com
Subject: Re: [PATCH] wifi: mac80211: check basic rates validity
Date: Tue, 30 Jul 2024 16:23:25 +0200 [thread overview]
Message-ID: <2024073014-borrowing-justifier-18c8@gregkh> (raw)
In-Reply-To: <20240729134318.291424-1-vincenzo.mezzela@gmail.com>
On Mon, Jul 29, 2024 at 03:43:18PM +0200, Vincenzo Mezzela wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> commit ce04abc3fcc62cd5640af981ebfd7c4dc3bded28 upstream.
>
> When userspace sets basic rates, it might send us some rates
> list that's empty or consists of invalid values only. We're
> currently ignoring invalid values and then may end up with a
> rates bitmap that's empty, which later results in a warning.
>
> Reject the call if there were no valid rates.
>
> [ Conflict resolution involved adjusting the patch to accommodate
> changes in the function signature of ieee80211_parse_bitrates and
> ieee80211_check_rate_mask ]
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> Reported-by: syzbot+07bee335584b04e7c2f8@syzkaller.appspotmail.com
> Tested-by: syzbot+07bee335584b04e7c2f8@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=07bee335584b04e7c2f8
> Signed-off-by: Vincenzo Mezzela <vincenzo.mezzela@gmail.com>
> ---
> Hi,
> please note that a backport of the same patch for v5.15 is available at
> [1].
Please resend [1] as it's gone from my queue.
greg k-h
next prev parent reply other threads:[~2024-07-30 14:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-29 13:43 [PATCH] wifi: mac80211: check basic rates validity Vincenzo Mezzela
2024-07-29 13:51 ` vincenzo mezzela
2024-07-30 14:23 ` Greg KH [this message]
2024-08-10 9:59 ` vincenzo mezzela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024073014-borrowing-justifier-18c8@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sashal@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+07bee335584b04e7c2f8@syzkaller.appspotmail.com \
--cc=vincenzo.mezzela@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).