From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 475C11A619B; Tue, 30 Jul 2024 16:37:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722357456; cv=none; b=rDNEmQcWpe9CNKWmqoC1ijuv3MtmyQKQtgFXydnB0Dxf4ONfPxPY/DJg3a3AilnMpidrxx/abv1l/XnR9bOKQVFMNxo//6Fi4Xo14YXLopGwi4XyijTo3xmlTtsjbwqDtk7kaAuxYCBFSE56LWZPbOJKOEGK/NhivBAFrZSf8Xg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722357456; c=relaxed/simple; bh=IZnrgju2UE3ttoRGRDJsGzu6kxTRyR3poGUPLXgoINI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S2GBGzIF7rpSEj9ZAWZnXNLMMqxsifRRVqvG/z59/zxXA3NaZXeSkpmWXG6C+0nMK0hxOWYwsKCGZmwe/GsTyY13kncRVgFXh8/2QZDZa6h0m8IAgGnZX41xq4H+oge2MZsixOupxBCgMuncOXfF/rz5vVfG6PNo9XdmVg1LCOk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DYx05w+l; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DYx05w+l" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 403A6C32782; Tue, 30 Jul 2024 16:37:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722357456; bh=IZnrgju2UE3ttoRGRDJsGzu6kxTRyR3poGUPLXgoINI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DYx05w+lggKad+7kxiOgbr3aKEnJcYXVTcXpmJO1psJ0eXGxezWdzPfeQ7m7yfbnj Odo7L/ufXiILOqVGaWgqQL57V/HWqSWUA1vEbTzj9YpeQyPNshVNDfvayjAhGeCFsn ND2RFfavrtRypdFsjgj4KkbBGhryQi7ZXF2MpNVaAtoXXbkTubysnkO55Q0X6zAd+r 8kkWTaz4YmZzEAf2dAjeLq6ZylejpAeUaWIktYWkceR5d3H/+4X4E2PpSLeEZS8dIS xrzwTH9EqndBn6IAMN+lH5U5+p+VF/ex0sngo2SoQ3nCrjkmjp8STkDkmWC9QwTwMR 2RaO6Vn/jjc0Q== Date: Tue, 30 Jul 2024 17:37:30 +0100 From: Simon Horman To: Marc Kleine-Budde Cc: kernel@pengutronix.de, Vincent Mailhol , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Philipp Zabel , Elaine Zhang , David Jander , linux-can@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH can-next 11/21] can: rockchip_canfd: add functions to check if CAN-FD frames are equal Message-ID: <20240730163730.GC1967603@kernel.org> References: <20240729-rockchip-canfd-v1-0-fa1250fd6be3@pengutronix.de> <20240729-rockchip-canfd-v1-11-fa1250fd6be3@pengutronix.de> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240729-rockchip-canfd-v1-11-fa1250fd6be3@pengutronix.de> On Mon, Jul 29, 2024 at 03:05:42PM +0200, Marc Kleine-Budde wrote: > Add a pair new functions to check if 2 struct canfd_frame are equal. > The 1st checks if the header of the CAN frames are equal, the 2nd > checks if the data portion are equal: > > - rkcanfd_can_frame_header_equal() > - rkcanfd_can_frame_data_equal() > > This functionality is needed in the next patch. nit: I would squash this into the next patch as rkcanfd_can_frame_header_equal() is defined but unused in this patch, which is flagged by allmodconfig W=1 builds. ...