From: Jakub Kicinski <kuba@kernel.org>
To: Dmitry Safonov via B4 Relay <devnull+0x7f454c46.gmail.com@kernel.org>
Cc: 0x7f454c46@gmail.com, Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@kernel.org
Subject: Re: [PATCH net v2] net/tcp: Disable TCP-AO static key after RCU grace period
Date: Tue, 30 Jul 2024 18:37:02 -0700 [thread overview]
Message-ID: <20240730183702.06aac434@kernel.org> (raw)
In-Reply-To: <20240730-tcp-ao-static-branch-rcu-v2-1-33dc2b7adac8@gmail.com>
On Tue, 30 Jul 2024 01:33:17 +0100 Dmitry Safonov via B4 Relay wrote:
> + struct hlist_node *n;
> +
> + hlist_for_each_entry_safe(key, n, &ao->head, node)
> + total_ao_sk_mem += tcp_ao_sizeof_key(key);
nit:
s/_safe//
no need to safely iterate if we're not modifying the list
--
pw-bot: cr
next prev parent reply other threads:[~2024-07-31 1:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 0:33 [PATCH net v2] net/tcp: Disable TCP-AO static key after RCU grace period Dmitry Safonov via B4 Relay
2024-07-31 1:37 ` Jakub Kicinski [this message]
2024-07-31 2:01 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240730183702.06aac434@kernel.org \
--to=kuba@kernel.org \
--cc=0x7f454c46@gmail.com \
--cc=davem@davemloft.net \
--cc=devnull+0x7f454c46.gmail.com@kernel.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).