netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
	eperezma@redhat.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com,
	virtualization@lists.linux.dev, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH V4 net-next 0/3] virtio-net: synchronize op/admin state
Date: Wed, 31 Jul 2024 10:59:44 +0800	[thread overview]
Message-ID: <20240731025947.23157-1-jasowang@redhat.com> (raw)

Hi All:

This series tries to synchronize the operstate with the admin state
which allows the lower virtio-net to propagate the link status to the
upper devices like macvlan.

This is done by toggling carrier during ndo_open/stop while doing
other necessary serialization about the carrier settings during probe.

Changes since V3:

- when driver tries to enable config interrupt, check pending
  interrupt and execute the nofitication change callback if necessary
- do not unconditonally trigger the config space read
- do not set LINK_UP flag in ndo_open/close but depends on the
  notification change
- disable config change notification until ndo_open()
- read the link status under the rtnl_lock() to prevent a race with
  ndo_open()

Changes since V2:

- introduce config_driver_disabled and helpers
- schedule config change work unconditionally

Thanks

Jason Wang (3):
  virtio: rename virtio_config_enabled to virtio_config_core_enabled
  virtio: allow driver to disable the configure change notification
  virtio-net: synchronize operstate with admin state on up/down

 drivers/net/virtio_net.c | 84 ++++++++++++++++++++++++++--------------
 drivers/virtio/virtio.c  | 59 +++++++++++++++++++++-------
 include/linux/virtio.h   | 11 +++++-
 3 files changed, 109 insertions(+), 45 deletions(-)

-- 
2.31.1


             reply	other threads:[~2024-07-31  3:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-31  2:59 Jason Wang [this message]
2024-07-31  2:59 ` [PATCH V4 net-next 1/3] virtio: rename virtio_config_enabled to virtio_config_core_enabled Jason Wang
2024-07-31  2:59 ` [PATCH V4 net-next 2/3] virtio: allow driver to disable the configure change notification Jason Wang
2024-07-31  2:59 ` [PATCH V4 net-next 3/3] virtio-net: synchronize operstate with admin state on up/down Jason Wang
2024-07-31 21:25   ` Michael S. Tsirkin
2024-08-01  2:16     ` Jason Wang
2024-08-01  5:58       ` Michael S. Tsirkin
2024-08-01  6:13         ` Jason Wang
2024-08-01  6:41           ` Michael S. Tsirkin
2024-08-01  6:55             ` Jason Wang
2024-08-01  7:00               ` Michael S. Tsirkin
2024-08-02  2:47                 ` Jason Wang
2024-08-01  6:05   ` Michael S. Tsirkin
2024-08-01  6:13     ` Jason Wang
2024-08-01  6:42       ` Michael S. Tsirkin
2024-08-01  6:55         ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240731025947.23157-1-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=eperezma@redhat.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=virtualization@lists.linux.dev \
    --cc=xuanzhuo@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).