From: Jakub Kicinski <kuba@kernel.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Paolo Abeni <pabeni@redhat.com>,
"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
Kees Cook <kees@kernel.org>,
netdev@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v2] net: core: annotate socks of struct sock_reuseport with __counted_by
Date: Wed, 31 Jul 2024 16:50:29 -0700 [thread overview]
Message-ID: <20240731165029.5f4b4e60@kernel.org> (raw)
In-Reply-To: <20240731045346.4087-1-dmantipov@yandex.ru>
On Wed, 31 Jul 2024 07:53:46 +0300 Dmitry Antipov wrote:
> + reuse = kzalloc(struct_size(reuse, socks, max_socks), GFP_ATOMIC);
>
> if (!reuse)
another nit -- no empty lines between function call and its error check
:)
Two bits of docs to look at before sending v3:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#resending-after-review
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#changes-requested
--
pw-bot: cr
prev parent reply other threads:[~2024-07-31 23:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 16:04 [PATCH] net: core: use __counted_by for trailing VLA of struct sock_reuseport Dmitry Antipov
2024-07-30 18:41 ` Gustavo A. R. Silva
2024-07-30 19:06 ` Kuniyuki Iwashima
2024-07-31 0:01 ` Jakub Kicinski
2024-07-31 4:53 ` [PATCH v2] net: core: annotate socks of struct sock_reuseport with __counted_by Dmitry Antipov
2024-07-31 23:50 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731165029.5f4b4e60@kernel.org \
--to=kuba@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=gustavo@embeddedor.com \
--cc=kees@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-hardening@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).