From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: "Song, Yoong Siang" <yoong.siang.song@intel.com>,
"Neftin, Sasha" <sasha.neftin@intel.com>,
Brett Creeley <brett.creeley@amd.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Blanco Alcaine, Hector" <hector.blanco.alcaine@intel.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Jonathan Corbet <corbet@lwn.net>,
"Gomes, Vinicius" <vinicius.gomes@intel.com>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
John Fastabend <john.fastabend@gmail.com>,
Shinas Rasheed <srasheed@marvell.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
Paolo Abeni <pabeni@redhat.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Hay, Joshua A" <joshua.a.hay@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next, v1 0/3] Add Default Rx Queue Setting for igc driver
Date: Wed, 31 Jul 2024 16:52:53 -0700 [thread overview]
Message-ID: <20240731165253.2571b254@kernel.org> (raw)
In-Reply-To: <d805bea3-cb2f-4e2c-a07a-27b8b4c5f294@intel.com>
On Wed, 31 Jul 2024 09:41:16 -0700 Jacob Keller wrote:
> In this case, (I haven't dug into the actual patches or code), I suspect
> the driver will need to validate the location values when adding rules
> to ensure that all rules which don't use the default queue have higher
> priority than the wild card rule. The request to add a filter should
> reject the rule in the case where a default queue rule was added with a
> higher priority location.
Maybe I shouldn't say it aloud but picking a "known" location for such
a wildcard rule wouldn't be the worst thing. Obviously better if the
driver just understand ordering!
next prev parent reply other threads:[~2024-07-31 23:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 1:22 [PATCH iwl-next,v1 0/3] Add Default Rx Queue Setting for igc driver Song Yoong Siang
2024-07-30 14:55 ` Jakub Kicinski
2024-07-31 7:40 ` Song, Yoong Siang
2024-07-31 14:43 ` Jakub Kicinski
2024-07-31 16:41 ` [Intel-wired-lan] [PATCH iwl-next, v1 " Jacob Keller
2024-07-31 23:52 ` Jakub Kicinski [this message]
2024-08-01 7:09 ` Song, Yoong Siang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731165253.2571b254@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brett.creeley@amd.com \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hector.blanco.alcaine@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=john.fastabend@gmail.com \
--cc=joshua.a.hay@intel.com \
--cc=kevin.tian@intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=sasha.neftin@intel.com \
--cc=srasheed@marvell.com \
--cc=vinicius.gomes@intel.com \
--cc=yoong.siang.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).