netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: netdev@vger.kernel.org, nbd@nbd.name,
	lorenzo.bianconi83@gmail.com, davem@davemloft.net,
	edumazet@google.com, pabeni@redhat.com,
	linux-arm-kernel@lists.infradead.org, upstream@airoha.com,
	angelogioacchino.delregno@collabora.com,
	benjamin.larsson@genexis.eu, rkannoth@marvell.com,
	sgoutham@marvell.com, andrew@lunn.ch, arnd@arndb.de,
	horms@kernel.org
Subject: Re: [PATCH net-next 2/9] net: airoha: Move airoha_queues in airoha_qdma
Date: Wed, 31 Jul 2024 19:15:43 -0700	[thread overview]
Message-ID: <20240731191543.2cc0c985@kernel.org> (raw)
In-Reply-To: <4b566f4f6feeb73f195863c01b7c9ae1ad01474a.1722356015.git.lorenzo@kernel.org>

On Tue, 30 Jul 2024 18:22:41 +0200 Lorenzo Bianconi wrote:
> QDMA controllers available in EN7581 SoC have independent tx/rx hw queues
> so move them in airoha_queues structure.

You seem to be touching a lot of the same lines you touched in the
previous patch here :(
Maybe you can add some of the

+	struct airoha_qdma *qdma = &q->eth->qdma[0];

lines, and propagate qdma pointers in the previous patch already?

  reply	other threads:[~2024-08-01  2:15 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-30 16:22 [PATCH net-next 0/9] Add second QDMA support for EN7581 eth controller Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 1/9] net: airoha: Introduce airoha_qdma struct Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 2/9] net: airoha: Move airoha_queues in airoha_qdma Lorenzo Bianconi
2024-08-01  2:15   ` Jakub Kicinski [this message]
2024-08-01 13:22     ` Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 3/9] net: airoha: Move irq_mask in airoha_qdma structure Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 4/9] net: airoha: Add airoha_qdma pointer in airoha_tx_irq_queue/airoha_queue structures Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 5/9] net: airoha: Use qdma pointer as private structure in airoha_irq_handler routine Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 6/9] net: airoha: Allow mapping IO region for multiple qdma controllers Lorenzo Bianconi
2024-08-01  2:14   ` Jakub Kicinski
2024-08-01  8:36     ` Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 7/9] net: airoha: Clean-up all qdma controllers running airoha_hw_cleanup() Lorenzo Bianconi
2024-08-01  2:14   ` Jakub Kicinski
2024-08-01  8:37     ` Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 8/9] net: airoha: Start all qdma NAPIs in airoha_probe() Lorenzo Bianconi
2024-07-30 16:22 ` [PATCH net-next 9/9] net: airoha: Link the gdm port to the selected qdma controller Lorenzo Bianconi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240731191543.2cc0c985@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnd@arndb.de \
    --cc=benjamin.larsson@genexis.eu \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=lorenzo.bianconi83@gmail.com \
    --cc=lorenzo@kernel.org \
    --cc=nbd@nbd.name \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rkannoth@marvell.com \
    --cc=sgoutham@marvell.com \
    --cc=upstream@airoha.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).