From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Kyle Swenson <kyle.swenson@est.tech>
Cc: "o.rempel@pengutronix.de" <o.rempel@pengutronix.de>,
"kory.maincent@bootlin.com" <kory.maincent@bootlin.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2] net: pse-pd: tps23881: Fix the device ID check
Date: Wed, 31 Jul 2024 21:26:27 +0200 [thread overview]
Message-ID: <20240731212627.16b1bcf1@windsurf> (raw)
In-Reply-To: <20240731154152.4020668-1-kyle.swenson@est.tech>
On Wed, 31 Jul 2024 15:42:14 +0000
Kyle Swenson <kyle.swenson@est.tech> wrote:
> The DEVID register contains two pieces of information: the device ID in
> the upper nibble, and the silicon revision number in the lower nibble.
> The driver should work fine with any silicon revision, so let's mask
> that out in the device ID check.
>
> Fixes: 20e6d190ffe1 ("net: pse-pd: Add TI TPS23881 PSE controller driver")
> Signed-off-by: Kyle Swenson <kyle.swenson@est.tech>
Thanks for the change!
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
next prev parent reply other threads:[~2024-07-31 19:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 15:42 [PATCH net-next v2] net: pse-pd: tps23881: Fix the device ID check Kyle Swenson
2024-07-31 19:26 ` Thomas Petazzoni [this message]
2024-08-02 7:53 ` Oleksij Rempel
2024-08-10 21:45 ` Kory Maincent
2024-08-12 15:41 ` Jakub Kicinski
2024-08-14 9:21 ` Kory Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240731212627.16b1bcf1@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=kyle.swenson@est.tech \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).