From: Jakub Kicinski <kuba@kernel.org>
To: Youwan Wang <youwan@nfschina.com>
Cc: linux@armlinux.org.uk, andrew@lunn.ch, davem@davemloft.net,
edumazet@google.com, hkallweit1@gmail.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, Russell King <rmk+kernel@armlinux.org.uk>,
Wojciech Drewek <wojciech.drewek@intel.com>
Subject: Re: [net-next,v4] net: phy: phy_device: fix PHY WOL enabled, PM failed to suspend
Date: Thu, 1 Aug 2024 08:51:23 -0700 [thread overview]
Message-ID: <20240801085123.6757d4c3@kernel.org> (raw)
In-Reply-To: <20240731091537.771391-1-youwan@nfschina.com>
On Wed, 31 Jul 2024 17:15:37 +0800 Youwan Wang wrote:
> + /* If the PHY on the mido bus is not attached but has WOL enabled
> + * we cannot suspend the PHY.
> + */
> + if (!netdev && phy_drv_wol_enabled(phydev))
> + return false;
Not sure why you stopped setting phydev->wol_enabled between v2 and v3
but let's hear from phy maintainers..
next prev parent reply other threads:[~2024-08-01 15:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-28 6:03 [PATCH] net: phy: phy_device: fix PHY WOL enabled, PM failed to suspend Youwan Wang
2024-06-28 8:17 ` Russell King (Oracle)
2024-06-28 8:25 ` Florian Fainelli
2024-06-28 8:38 ` Russell King (Oracle)
2024-06-28 8:48 ` Florian Fainelli
2024-06-28 9:24 ` Russell King (Oracle)
2024-06-28 9:37 ` Florian Fainelli
[not found] ` <20240701062144.552508-1-youwan@nfschina.com>
2024-07-01 16:32 ` [net-next,v1] " Andrew Lunn
2024-07-09 11:37 ` [net-next,v2] " Youwan Wang
2024-07-29 8:03 ` Russell King (Oracle)
2024-07-30 8:15 ` [net-next,v3] " Youwan Wang
2024-07-30 9:28 ` Wojciech Drewek
2024-07-31 9:15 ` [net-next,v4] " Youwan Wang
2024-07-31 13:41 ` Jakub Kicinski
2024-08-01 15:51 ` Jakub Kicinski [this message]
2024-08-07 2:40 ` patchwork-bot+netdevbpf
2024-07-30 0:48 ` [net-next,v3] " Youwan Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801085123.6757d4c3@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=wojciech.drewek@intel.com \
--cc=youwan@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).