From: Simon Horman <horms@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, kernel test robot <lkp@intel.com>,
alexanderduyck@fb.com
Subject: Re: [PATCH net] eth: fbnic: select devlink
Date: Fri, 2 Aug 2024 16:31:33 +0100 [thread overview]
Message-ID: <20240802153133.GF2504122@kernel.org> (raw)
In-Reply-To: <20240802080148.53366633@kernel.org>
On Fri, Aug 02, 2024 at 08:01:48AM -0700, Jakub Kicinski wrote:
> On Fri, 2 Aug 2024 15:50:38 +0100 Simon Horman wrote:
> > But while exercising this I noticed that PAGE_POOL is also needed,
> > which I locally resolved by adding:
>
> Oh, good catch. I'm a bit surprised how slow kbuild bot is :(
>
> > select PAGE_POOL
> >
> > I can provide a follow-up patch after this one is merged.
> > Or perhaps you can address this in a v2?
> > I have no preference either way.
>
> Please send your version with both selects, I'll mark mine as superseded
Sure. I'll set myself as the author, to save negotiating about that,
and as it's only two lines. Do feel free to update as you see fit.
prev parent reply other threads:[~2024-08-02 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 1:59 [PATCH net] eth: fbnic: select devlink Jakub Kicinski
2024-08-02 14:50 ` Simon Horman
2024-08-02 15:01 ` Jakub Kicinski
2024-08-02 15:31 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802153133.GF2504122@kernel.org \
--to=horms@kernel.org \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).