From: Jakub Kicinski <kuba@kernel.org>
To: Praveen Kaligineedi <pkaligineedi@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, willemb@google.com, jeroendb@google.com,
shailend@google.com, hramamurthy@google.com, jfraker@google.com,
Ziwei Xiao <ziweixiao@google.com>
Subject: Re: [PATCH net-next 1/2] gve: Add RSS device option
Date: Fri, 2 Aug 2024 16:13:35 -0700 [thread overview]
Message-ID: <20240802161335.0e23e9ec@kernel.org> (raw)
In-Reply-To: <20240802012834.1051452-2-pkaligineedi@google.com>
On Thu, 1 Aug 2024 18:28:33 -0700 Praveen Kaligineedi wrote:
> @@ -45,7 +45,8 @@ void gve_parse_device_option(struct gve_priv *priv,
> struct gve_device_option_dqo_qpl **dev_op_dqo_qpl,
> struct gve_device_option_buffer_sizes **dev_op_buffer_sizes,
> struct gve_device_option_flow_steering **dev_op_flow_steering,
> - struct gve_device_option_modify_ring **dev_op_modify_ring)
> + struct gve_device_option_modify_ring **dev_op_modify_ring,
> + struct gve_device_option_rss_config **dev_op_rss_config)
> {
> u32 req_feat_mask = be32_to_cpu(option->required_features_mask);
> u16 option_length = be16_to_cpu(option->option_length);
> @@ -867,6 +887,8 @@ static void gve_enable_supported_features(struct gve_priv *priv,
> *dev_op_buffer_sizes,
> const struct gve_device_option_flow_steering
> *dev_op_flow_steering,
> + const struct gve_device_option_rss_config
> + *dev_op_rss_config,
> const struct gve_device_option_modify_ring
> *dev_op_modify_ring)
Any reason these two functions order the arguments differently?
next prev parent reply other threads:[~2024-08-02 23:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 1:28 [PATCH net-next 0/2] gve: Add RSS config support Praveen Kaligineedi
2024-08-02 1:28 ` [PATCH net-next 1/2] gve: Add RSS device option Praveen Kaligineedi
2024-08-02 23:13 ` Jakub Kicinski [this message]
2024-08-06 0:08 ` Ziwei Xiao
2024-08-02 1:28 ` [PATCH net-next 2/2] gve: Add RSS adminq commands and ethtool support Praveen Kaligineedi
2024-08-02 23:21 ` Jakub Kicinski
2024-08-06 0:07 ` Ziwei Xiao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802161335.0e23e9ec@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=jeroendb@google.com \
--cc=jfraker@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkaligineedi@google.com \
--cc=shailend@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).