From: Stephen Hemminger <stephen@networkplumber.org>
To: "Andreas K. Hüttel" <dilfridge@gentoo.org>
Cc: netdev@vger.kernel.org, base-system@gentoo.org
Subject: Re: [PATCH v2 iproute2] libnetlink.h: Include <endian.h> explicitly for musl
Date: Sun, 4 Aug 2024 09:58:11 -0700 [thread overview]
Message-ID: <20240804095811.04600a4d@hermes.local> (raw)
In-Reply-To: <20240804160355.940167-1-dilfridge@gentoo.org>
On Sun, 4 Aug 2024 18:03:23 +0200
Andreas K. Hüttel <dilfridge@gentoo.org> wrote:
> The code added in "f_flower: implement pfcp opts" uses h2be64,
> defined in endian.h. While this is pulled in around some corners
> for glibc (see below), that's not the case for musl and an
> explicit include is required there.
>
> . /usr/include/libmnl/libmnl.h
> .. /usr/include/sys/socket.h
> ... /usr/include/bits/socket.h
> .... /usr/include/sys/types.h
> ..... /usr/include/endian.h
>
> Fixes: 976dca372 ("f_flower: implement pfcp opts")
> Bug: https://bugs.gentoo.org/936234
> Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>
Other parts of flower code use htonll().
It would have been better to be consistent and not use h2be64() at all.
next prev parent reply other threads:[~2024-08-04 16:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 14:57 [PATCH iproute2] libnetlink.h: Include <endian.h> explicitly for musl Andreas K. Hüttel
2024-08-04 15:55 ` Stephen Hemminger
2024-08-04 16:03 ` [PATCH v2 " Andreas K. Hüttel
2024-08-04 16:58 ` Stephen Hemminger [this message]
2024-08-04 17:07 ` Mike Gilbert
2024-08-04 17:09 ` Mike Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240804095811.04600a4d@hermes.local \
--to=stephen@networkplumber.org \
--cc=base-system@gentoo.org \
--cc=dilfridge@gentoo.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).