* [PATCH net-next] net: airoha: honor reset return value in airoha_hw_init()
@ 2024-08-03 15:50 Lorenzo Bianconi
2024-08-05 13:49 ` Simon Horman
2024-08-06 20:28 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2024-08-03 15:50 UTC (permalink / raw)
To: netdev
Cc: nbd, sean.wang, Mark-MC.Lee, davem, edumazet, kuba, pabeni,
linux-arm-kernel, linux-mediatek, lorenzo.bianconi83
Take into account return value from reset_control_bulk_assert and
reset_control_bulk_deassert routines in airoha_hw_init().
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
drivers/net/ethernet/mediatek/airoha_eth.c | 16 ++++++++++++----
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/mediatek/airoha_eth.c b/drivers/net/ethernet/mediatek/airoha_eth.c
index db4267225fa4..1fb46db0c1e9 100644
--- a/drivers/net/ethernet/mediatek/airoha_eth.c
+++ b/drivers/net/ethernet/mediatek/airoha_eth.c
@@ -2071,13 +2071,21 @@ static int airoha_hw_init(struct platform_device *pdev,
int err, i;
/* disable xsi */
- reset_control_bulk_assert(ARRAY_SIZE(eth->xsi_rsts), eth->xsi_rsts);
+ err = reset_control_bulk_assert(ARRAY_SIZE(eth->xsi_rsts),
+ eth->xsi_rsts);
+ if (err)
+ return err;
+
+ err = reset_control_bulk_assert(ARRAY_SIZE(eth->rsts), eth->rsts);
+ if (err)
+ return err;
- reset_control_bulk_assert(ARRAY_SIZE(eth->rsts), eth->rsts);
- msleep(20);
- reset_control_bulk_deassert(ARRAY_SIZE(eth->rsts), eth->rsts);
msleep(20);
+ err = reset_control_bulk_deassert(ARRAY_SIZE(eth->rsts), eth->rsts);
+ if (err)
+ return err;
+ msleep(20);
err = airoha_fe_init(eth);
if (err)
return err;
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: airoha: honor reset return value in airoha_hw_init()
2024-08-03 15:50 [PATCH net-next] net: airoha: honor reset return value in airoha_hw_init() Lorenzo Bianconi
@ 2024-08-05 13:49 ` Simon Horman
2024-08-06 20:28 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-08-05 13:49 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: netdev, nbd, sean.wang, Mark-MC.Lee, davem, edumazet, kuba,
pabeni, linux-arm-kernel, linux-mediatek, lorenzo.bianconi83
On Sat, Aug 03, 2024 at 05:50:50PM +0200, Lorenzo Bianconi wrote:
> Take into account return value from reset_control_bulk_assert and
> reset_control_bulk_deassert routines in airoha_hw_init().
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: airoha: honor reset return value in airoha_hw_init()
2024-08-03 15:50 [PATCH net-next] net: airoha: honor reset return value in airoha_hw_init() Lorenzo Bianconi
2024-08-05 13:49 ` Simon Horman
@ 2024-08-06 20:28 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-06 20:28 UTC (permalink / raw)
To: Lorenzo Bianconi
Cc: netdev, nbd, sean.wang, Mark-MC.Lee, davem, edumazet, kuba,
pabeni, linux-arm-kernel, linux-mediatek, lorenzo.bianconi83
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 3 Aug 2024 17:50:50 +0200 you wrote:
> Take into account return value from reset_control_bulk_assert and
> reset_control_bulk_deassert routines in airoha_hw_init().
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> drivers/net/ethernet/mediatek/airoha_eth.c | 16 ++++++++++++----
> 1 file changed, 12 insertions(+), 4 deletions(-)
Here is the summary with links:
- [net-next] net: airoha: honor reset return value in airoha_hw_init()
https://git.kernel.org/netdev/net-next/c/63a796b4988c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-08-06 20:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-03 15:50 [PATCH net-next] net: airoha: honor reset return value in airoha_hw_init() Lorenzo Bianconi
2024-08-05 13:49 ` Simon Horman
2024-08-06 20:28 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).