From: Jakub Kicinski <kuba@kernel.org>
To: Randy Li <ayaka@soulik.info>
Cc: netdev@vger.kernel.org, willemdebruijn.kernel@gmail.com,
jasowang@redhat.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: tuntap: add ioctl() TUNGETQUEUEINDEX to fetch queue index
Date: Tue, 6 Aug 2024 12:00:37 -0700 [thread overview]
Message-ID: <20240806120037.76a279fe@kernel.org> (raw)
In-Reply-To: <20240801134929.206678-1-ayaka@soulik.info>
On Thu, 1 Aug 2024 21:49:21 +0800 Randy Li wrote:
> + if(put_user(tfile->queue_index, (unsigned int __user*)argp))
Checkpatch has some legitimate complains about this line:
ERROR: "(foo*)" should be "(foo *)"
#58: FILE: drivers/net/tun.c:3160:
+ if(put_user(tfile->queue_index, (unsigned int __user*)argp))
ERROR: space required before the open parenthesis '('
#58: FILE: drivers/net/tun.c:3160:
+ if(put_user(tfile->queue_index, (unsigned int __user*)argp))
Assuming Willem is okay with the feature, please add appropriate tests
in tools/testing/selftests/net/tap.c
--
pw-bot: cr
prev parent reply other threads:[~2024-08-06 19:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-01 13:49 [PATCH net-next v2] net: tuntap: add ioctl() TUNGETQUEUEINDEX to fetch queue index Randy Li
2024-08-06 19:00 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806120037.76a279fe@kernel.org \
--to=kuba@kernel.org \
--cc=ayaka@soulik.info \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).