From: Simon Horman <horms@kernel.org>
To: Christian Hopps <chopps@chopps.org>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
netdev@vger.kernel.org, Christian Hopps <chopps@labn.net>,
devel@linux-ipsec.org
Subject: Re: [devel-ipsec] [PATCH ipsec-next v8 08/16] xfrm: iptfs: add user packet (tunnel ingress) handling
Date: Tue, 6 Aug 2024 16:24:57 +0100 [thread overview]
Message-ID: <20240806152457.GA2636630@kernel.org> (raw)
In-Reply-To: <m27ccuosuu.fsf@ja-home.int.chopps.org>
On Tue, Aug 06, 2024 at 06:19:28AM -0400, Christian Hopps wrote:
>
> Simon Horman via Devel <devel@linux-ipsec.org> writes:
>
> > On Sun, Aug 04, 2024 at 04:33:37PM -0400, Christian Hopps wrote:
> > > From: Christian Hopps <chopps@labn.net>
> > >
> > > Add tunnel packet output functionality. This is code handles
> > > the ingress to the tunnel.
> > >
> > > Signed-off-by: Christian Hopps <chopps@labn.net>
> >
> > ...
> >
> > > +static int iptfs_prepare_output(struct xfrm_state *x, struct sk_buff *skb)
> > > +{
> > > + if (x->outer_mode.family == AF_INET)
> > > + return iptfs_encap_add_ipv4(x, skb);
> > > + if (x->outer_mode.family == AF_INET6) {
> > > +#if IS_ENABLED(CONFIG_IPV6)
> > > + return iptfs_encap_add_ipv6(x, skb);
> >
> > iptfs_encap_add_ipv6 is flagged as unused when IPV6 is not enabled.
> > Perhaps it should also be wrapped in a CONFIG_IPV6 check.
>
> Done, and tested with CONFIG_IPV6=n.
Thanks!
next prev parent reply other threads:[~2024-08-06 15:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 20:33 [PATCH ipsec-next v8 00/16] Add IP-TFS mode to xfrm Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 01/16] xfrm: config: add CONFIG_XFRM_IPTFS Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 02/16] include: uapi: add ip_tfs_*_hdr packet formats Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 03/16] include: uapi: add IPPROTO_AGGFRAG for AGGFRAG in ESP Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 04/16] xfrm: netlink: add config (netlink) options Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 05/16] xfrm: add mode_cbs module functionality Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 06/16] xfrm: add generic iptfs defines and functionality Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 07/16] xfrm: iptfs: add new iptfs xfrm mode impl Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 08/16] xfrm: iptfs: add user packet (tunnel ingress) handling Christian Hopps
2024-08-05 17:10 ` Simon Horman
2024-08-06 10:19 ` [devel-ipsec] " Christian Hopps
2024-08-06 15:24 ` Simon Horman [this message]
2024-08-04 20:33 ` [PATCH ipsec-next v8 09/16] xfrm: iptfs: share page fragments of inner packets Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 10/16] xfrm: iptfs: add fragmenting of larger than MTU user packets Christian Hopps
2024-08-04 22:25 ` Sabrina Dubroca
2024-08-05 2:33 ` Christian Hopps
2024-08-05 4:19 ` Christian Hopps
2024-08-06 8:47 ` Sabrina Dubroca
2024-08-06 8:54 ` Christian Hopps
2024-08-06 10:03 ` Florian Westphal
2024-08-06 10:05 ` Christian Hopps
2024-08-06 11:05 ` Sabrina Dubroca
2024-08-06 11:07 ` Christian Hopps
2024-08-08 11:30 ` Christian Hopps
2024-08-08 13:28 ` Sabrina Dubroca
2024-08-08 13:35 ` Christian Hopps
2024-08-08 14:01 ` Sabrina Dubroca
2024-08-08 21:42 ` Christian Hopps
2024-08-06 11:07 ` Steffen Klassert
2024-08-07 16:23 ` Christian Hopps
2024-08-06 11:32 ` Steffen Klassert
2024-08-07 19:40 ` Christian Hopps
2024-08-08 9:26 ` Sabrina Dubroca
2024-08-08 11:23 ` Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 11/16] xfrm: iptfs: add basic receive packet (tunnel egress) handling Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 12/16] xfrm: iptfs: handle received fragmented inner packets Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 13/16] xfrm: iptfs: add reusing received skb for the tunnel egress packet Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 14/16] xfrm: iptfs: add skb-fragment sharing code Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 15/16] xfrm: iptfs: handle reordering of received packets Christian Hopps
2024-08-04 20:33 ` [PATCH ipsec-next v8 16/16] xfrm: iptfs: add tracepoint functionality Christian Hopps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806152457.GA2636630@kernel.org \
--to=horms@kernel.org \
--cc=chopps@chopps.org \
--cc=chopps@labn.net \
--cc=devel@linux-ipsec.org \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).