From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>, <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>
Subject: Re: [PATCH net-next 06/11] net/mlx5e: Use extack in set ringparams callback
Date: Tue, 6 Aug 2024 18:16:56 -0700 [thread overview]
Message-ID: <20240806181656.2c908cfd@kernel.org> (raw)
In-Reply-To: <20240806125804.2048753-7-tariqt@nvidia.com>
On Tue, 6 Aug 2024 15:57:59 +0300 Tariq Toukan wrote:
> if (param->rx_jumbo_pending) {
> - netdev_info(priv->netdev, "%s: rx_jumbo_pending not supported\n",
> - __func__);
> + NL_SET_ERR_MSG_MOD(extack, "rx-jumbo not supported");
> return -EINVAL;
> }
> if (param->rx_mini_pending) {
> - netdev_info(priv->netdev, "%s: rx_mini_pending not supported\n",
> - __func__);
> + NL_SET_ERR_MSG_MOD(extack, "rx-mini not supported");
> return -EINVAL;
> }
This is dead code in the first place, mlx5 doesn't set associated max
values so:
if (ringparam.rx_pending > max.rx_max_pending ||
ringparam.rx_mini_pending > max.rx_mini_max_pending ||
ringparam.rx_jumbo_pending > max.rx_jumbo_max_pending ||
ringparam.tx_pending > max.tx_max_pending)
return -EINVAL;
in the core will reject any attempts at using these.
next prev parent reply other threads:[~2024-08-07 1:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 12:57 [PATCH net-next 00/11] mlx5 misc patches 2024-08-06 Tariq Toukan
2024-08-06 12:57 ` [PATCH net-next 01/11] net/mlx5: E-Switch, Increase max int port number for offload Tariq Toukan
2024-08-06 12:57 ` [PATCH net-next 02/11] net/mlx5e: Enable remove flow for hard packet limit Tariq Toukan
2024-08-06 12:57 ` [PATCH net-next 03/11] net/mlx5e: TC, Offload rewrite and mirror on tunnel over ovs internal port Tariq Toukan
2024-08-06 12:57 ` [PATCH net-next 04/11] net/mlx5e: TC, Offload rewrite and mirror to both internal and external dests Tariq Toukan
2024-08-06 12:57 ` [PATCH net-next 05/11] net/mlx5e: Be consistent with bitmap handling of link modes Tariq Toukan
2024-08-06 12:57 ` [PATCH net-next 06/11] net/mlx5e: Use extack in set ringparams callback Tariq Toukan
2024-08-07 1:16 ` Jakub Kicinski [this message]
2024-08-07 6:22 ` Gal Pressman
2024-08-06 12:58 ` [PATCH net-next 07/11] net/mlx5e: Use extack in get coalesce callback Tariq Toukan
2024-08-06 12:58 ` [PATCH net-next 08/11] net/mlx5e: Use extack in set " Tariq Toukan
2024-08-06 12:58 ` [PATCH net-next 09/11] net/mlx5e: Use extack in get module eeprom by page callback Tariq Toukan
2024-08-06 12:58 ` [PATCH net-next 10/11] net/mlx5e: CT: 'update' rules instead of 'replace' Tariq Toukan
2024-08-06 12:58 ` [PATCH net-next 11/11] net/mlx5e: CT: Update connection tracking steering entries Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240806181656.2c908cfd@kernel.org \
--to=kuba@kernel.org \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).