netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
	<edumazet@google.com>, <pabeni@redhat.com>,
	<ilias.apalodimas@linaro.org>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	Alexander Duyck <alexander.duyck@gmail.com>,
	Yonglong Liu <liuyonglong@huawei.com>
Subject: Re: [RFC net] net: make page pool stall netdev unregistration to avoid IOMMU crashes
Date: Wed, 7 Aug 2024 07:29:08 -0700	[thread overview]
Message-ID: <20240807072908.1da91994@kernel.org> (raw)
In-Reply-To: <523894ab-2d38-415f-8306-c0d1abd911ec@huawei.com>

On Wed, 7 Aug 2024 19:00:35 +0800 Yunsheng Lin wrote:
> > Note that page pool pages may last forever, we have seen it happen
> > e.g. when application leaks a socket and page is stuck in its rcv queue.  
> 
> We saw some page_pool pages might last forever too, but were not sure
> if it was the same reason as above? Are there some cmds/ways to debug
> if a application leaks a socket and page is stuck in its rcv queue?

I used drgn to scan all sockets to find the page.

> > Hopefully this is fine in this particular case, as we will only stall
> > unregistering of devices which want the page pool to manage the DMA
> > mapping for them, i.e. HW backed netdevs. And obviously keeping
> > the netdev around is preferable to a crash.

  reply	other threads:[~2024-08-07 14:29 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-06 15:16 [RFC net] net: make page pool stall netdev unregistration to avoid IOMMU crashes Jakub Kicinski
2024-08-07  7:03 ` Yonglong Liu
2024-08-07 14:27   ` Jakub Kicinski
2024-08-08  1:11     ` Yonglong Liu
2024-08-07 11:00 ` Yunsheng Lin
2024-08-07 14:29   ` Jakub Kicinski [this message]
2024-08-08 12:52     ` Yonglong Liu
2024-08-08 14:05       ` Jakub Kicinski
2024-08-09  6:06         ` Yonglong Liu
2024-08-10  3:57           ` Jakub Kicinski
2024-08-14 10:09             ` Yonglong Liu
2024-08-14 14:56               ` Jakub Kicinski
2024-08-08 11:12 ` Ilias Apalodimas
2024-08-08 13:52   ` Jakub Kicinski
2024-08-08 14:30     ` Ilias Apalodimas
2024-08-08 14:51       ` Jakub Kicinski
2024-09-05 10:47 ` Yunsheng Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240807072908.1da91994@kernel.org \
    --to=kuba@kernel.org \
    --cc=alexander.duyck@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=linyunsheng@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).