From: Randy Li <ayaka@soulik.info>
To: netdev@vger.kernel.org
Cc: willemdebruijn.kernel@gmail.com, jasowang@redhat.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-kernel@vger.kernel.org,
Randy Li <ayaka@soulik.info>
Subject: [PATCH net-next v3] net: tuntap: add ioctl() TUNGETQUEUEINDEX to fetch queue index
Date: Thu, 8 Aug 2024 03:02:30 +0800 [thread overview]
Message-ID: <20240807190236.136388-1-ayaka@soulik.info> (raw)
We need the queue index in qdisc mapping rule and the result
value for the steering eBPF.
There was no way to know that.
Changelog:
v3:
fixes two style issues in the previous commit
v2:
Fixes the flow when the queue is disabled in the tap type device.
Put this ioctl() under the lock protection for the tun device.
Signed-off-by: Randy Li <ayaka@soulik.info>
---
drivers/net/tap.c | 10 ++++++++++
drivers/net/tun.c | 13 +++++++++++++
include/uapi/linux/if_tun.h | 1 +
3 files changed, 24 insertions(+)
diff --git a/drivers/net/tap.c b/drivers/net/tap.c
index 77574f7a3bd4..bbd717cf78a5 100644
--- a/drivers/net/tap.c
+++ b/drivers/net/tap.c
@@ -1120,6 +1120,16 @@ static long tap_ioctl(struct file *file, unsigned int cmd,
rtnl_unlock();
return ret;
+ case TUNGETQUEUEINDEX:
+ rtnl_lock();
+ if (!q->enabled)
+ ret = -EINVAL;
+ else
+ ret = put_user(q->queue_index, up);
+
+ rtnl_unlock();
+ return ret;
+
case SIOCGIFHWADDR:
rtnl_lock();
tap = tap_get_tap_dev(q);
diff --git a/drivers/net/tun.c b/drivers/net/tun.c
index 1d06c560c5e6..0c527ccdeab3 100644
--- a/drivers/net/tun.c
+++ b/drivers/net/tun.c
@@ -3151,6 +3151,19 @@ static long __tun_chr_ioctl(struct file *file, unsigned int cmd,
tfile->ifindex = ifindex;
goto unlock;
}
+ if (cmd == TUNGETQUEUEINDEX) {
+ ret = -EINVAL;
+ if (tfile->detached)
+ goto unlock;
+
+ ret = -EFAULT;
+ if (put_user(tfile->queue_index, (unsigned int __user *)argp))
+ goto unlock;
+
+ ret = 0;
+ goto unlock;
+ }
+
ret = -EBADFD;
if (!tun)
diff --git a/include/uapi/linux/if_tun.h b/include/uapi/linux/if_tun.h
index 287cdc81c939..2668ca3b06a5 100644
--- a/include/uapi/linux/if_tun.h
+++ b/include/uapi/linux/if_tun.h
@@ -61,6 +61,7 @@
#define TUNSETFILTEREBPF _IOR('T', 225, int)
#define TUNSETCARRIER _IOW('T', 226, int)
#define TUNGETDEVNETNS _IO('T', 227)
+#define TUNGETQUEUEINDEX _IOR('T', 228, unsigned int)
/* TUNSETIFF ifr flags */
#define IFF_TUN 0x0001
--
2.45.2
next reply other threads:[~2024-08-07 19:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 19:02 Randy Li [this message]
2024-08-08 2:16 ` [PATCH net-next v3] net: tuntap: add ioctl() TUNGETQUEUEINDEX to fetch queue index Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240807190236.136388-1-ayaka@soulik.info \
--to=ayaka@soulik.info \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox