[PATCH] net: pse-pd: tps23881: include missing bitfield.h header

[PATCH] net: pse-pd: tps23881: include missing bitfield.h header

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

Using FIELD_GET() fails in configurations that don't already include
the header file indirectly:

drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
  755 |         if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
      |             ^~~~~~~~~

Fixes: 89108cb5c285 ("net: pse-pd: tps23881: Fix the device ID check")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/pse-pd/tps23881.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/pse-pd/tps23881.c b/drivers/net/pse-pd/tps23881.c
index f90db758554b..2ea75686a319 100644
--- a/drivers/net/pse-pd/tps23881.c
+++ b/drivers/net/pse-pd/tps23881.c
@@ -5,6 +5,7 @@
  * Copyright (c) 2023 Bootlin, Kory Maincent <kory.maincent@bootlin.com>
  */
 
+#include <linux/bitfield.h>
 #include <linux/delay.h>
 #include <linux/firmware.h>
 #include <linux/i2c.h>
-- 
2.39.2

Re: [PATCH] net: pse-pd: tps23881: include missing bitfield.h header

[Oleksij Rempel]

Hi Arnd,

Thank you for your patch.

I acked already other one:
https://lore.kernel.org/all/20240807071538.569784-1-guanjun@linux.alibaba.com/

On Wed, Aug 07, 2024 at 09:54:22AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Using FIELD_GET() fails in configurations that don't already include
> the header file indirectly:
> 
> drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
> drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
>   755 |         if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
>       |             ^~~~~~~~~
> 
> Fixes: 89108cb5c285 ("net: pse-pd: tps23881: Fix the device ID check")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>


Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [PATCH] net: pse-pd: tps23881: include missing bitfield.h header

[Jakub Kicinski]

On Wed, 7 Aug 2024 11:13:48 +0200 Oleksij Rempel wrote:
> I acked already other one:
> https://lore.kernel.org/all/20240807071538.569784-1-guanjun@linux.alibaba.com/

Thanks for the note, I totally missed the other patch scanning for just
fixes before the downstream PR.

I prefer Arnd's fix TBH, apart from not having the wrong tree in the
subject - the fixes tag is correctly formatted and includes are kept
alphabetical.

I'll "move" your ack here, hope that's fine.

Re: [PATCH] net: pse-pd: tps23881: include missing bitfield.h header

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  7 Aug 2024 09:54:22 +0200 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Using FIELD_GET() fails in configurations that don't already include
> the header file indirectly:
> 
> drivers/net/pse-pd/tps23881.c: In function 'tps23881_i2c_probe':
> drivers/net/pse-pd/tps23881.c:755:13: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
>   755 |         if (FIELD_GET(TPS23881_REG_DEVID_MASK, ret) != TPS23881_DEVICE_ID) {
>       |             ^~~~~~~~~
> 
> [...]

Here is the summary with links:
  - net: pse-pd: tps23881: include missing bitfield.h header
    https://git.kernel.org/netdev/net/c/a70b637db15b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html