From: Jakub Kicinski <kuba@kernel.org>
To: Abhinav Jain <jain.abhinav177@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
shuah@kernel.org, netdev@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
skhan@linuxfoundation.org, javier.carrasco.cruz@gmail.com
Subject: Re: [PATCH v5 1/2] selftests: net: Create veth pair for testing in networkless kernel
Date: Thu, 8 Aug 2024 09:23:09 -0700 [thread overview]
Message-ID: <20240808092309.2a811cf4@kernel.org> (raw)
In-Reply-To: <20240808122452.25683-2-jain.abhinav177@gmail.com>
On Thu, 8 Aug 2024 12:24:51 +0000 Abhinav Jain wrote:
> Check if the netdev list is empty and create veth pair to be used for
> feature on/off testing.
> Remove the veth pair after testing is complete.
A number of checks now return SKIP because veth doesn't support all
ethtool APIs.
In netdev selftests we try to make sure SKIP is only used when test
cannot be performed because of limitations of the environment.
For example some tool is not installed, kernel doesn't have a config.
Something that the person running the test is able to fix by fixing
how the test is run.
Running this test on veth will always SKIP, nothing CI system can do.
Please make the test use the keyword XFAIL instead of SKIP when
functionality is not supported by the underlying driver.
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-08 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 12:24 [PATCH v5 0/2] Enhance network interface feature testing Abhinav Jain
2024-08-08 12:24 ` [PATCH v5 1/2] selftests: net: Create veth pair for testing in networkless kernel Abhinav Jain
2024-08-08 16:23 ` Jakub Kicinski [this message]
2024-08-09 16:53 ` Abhinav Jain
2024-08-10 4:19 ` Jakub Kicinski
2024-08-10 17:55 ` Abhinav Jain
2024-08-08 12:24 ` [PATCH v5 2/2] selftests: net: Add on/off checks for non-fixed features of interface Abhinav Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808092309.2a811cf4@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jain.abhinav177@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).