From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Przemek Kitszel <przemyslaw.kitszel@intel.com>,
netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
Petr Machata <petrm@nvidia.com>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com,
Wojciech Drewek <wojciech.drewek@intel.com>
Subject: Re: [PATCH net-next 4/5] devlink: embed driver's priv data callback param into devlink_resource
Date: Thu, 8 Aug 2024 19:41:50 -0700 [thread overview]
Message-ID: <20240808194150.1ac32478@kernel.org> (raw)
In-Reply-To: <ZrMZFWvo20hn49He@nanopsycho.orion>
On Wed, 7 Aug 2024 08:49:57 +0200 Jiri Pirko wrote:
> > lockdep_assert_held(&devlink->lock);
> >
> > resource = devlink_resource_find(devlink, NULL, resource_id);
> >- if (WARN_ON(!resource))
> >+ if (WARN_ON(!resource || occ_priv_size > resource->priv_size))
>
> Very odd. You allocate a mem in devl_resource_register() and here you
> copy data to it. Why the void pointer is not enough for you? You can
> easily alloc struct in the driver and pass a pointer to it.
>
> This is quite weird. Please don't.
The patch is a bit of a half measure, true.
Could you shed more light on the design choices for the resource API,
tho? Why the tying of objects by driver-defined IDs? It looks like
the callback for getting resources occupancy is "added" later once
the resource is registered? Is this some legacy of the old locking
scheme? It's quite unusual.
next prev parent reply other threads:[~2024-08-09 2:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 14:33 [PATCH net-next 0/5] devlink: embed driver's priv data callback param into devlink_resource Przemek Kitszel
2024-08-06 14:33 ` [PATCH net-next 1/5] net: dsa: replace devlink resource registration calls by devl_ variants Przemek Kitszel
2024-08-06 14:33 ` [PATCH net-next 2/5] devlink: remove unused devlink_resource_occ_get_register() and _unregister() Przemek Kitszel
2024-08-06 14:33 ` [PATCH net-next 3/5] devlink: remove unused devlink_resource_register() Przemek Kitszel
2024-08-06 14:33 ` [PATCH net-next 4/5] devlink: embed driver's priv data callback param into devlink_resource Przemek Kitszel
2024-08-07 6:49 ` Jiri Pirko
2024-08-09 2:41 ` Jakub Kicinski [this message]
2024-08-09 11:02 ` Jiri Pirko
2024-08-12 11:50 ` Przemek Kitszel
2024-08-12 15:00 ` Jiri Pirko
2024-08-13 3:45 ` Przemek Kitszel
2024-08-13 5:41 ` Jiri Pirko
2024-08-16 8:33 ` kernel test robot
2024-08-06 14:33 ` [PATCH net-next 5/5] mlxsw: spectrum_kvdl: combine devlink resource occupation getters Przemek Kitszel
2024-08-07 6:47 ` Jiri Pirko
2024-08-12 11:23 ` Przemek Kitszel
2024-08-12 15:01 ` Jiri Pirko
2024-08-07 6:51 ` [PATCH net-next 0/5] devlink: embed driver's priv data callback param into devlink_resource Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240808194150.1ac32478@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).