From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
michael.chan@broadcom.com, shuah@kernel.org,
ecree.xilinx@gmail.com, przemyslaw.kitszel@intel.com,
ahmed.zaki@intel.com, andrew@lunn.ch, willemb@google.com,
pavan.chebbi@broadcom.com, petrm@nvidia.com, gal@nvidia.com,
jdamato@fastly.com, donald.hunter@gmail.com,
Jakub Kicinski <kuba@kernel.org>
Subject: [PATCH net-next v4 01/12] selftests: drv-net: rss_ctx: add identifier to traffic comments
Date: Thu, 8 Aug 2024 20:18:16 -0700 [thread overview]
Message-ID: <20240809031827.2373341-2-kuba@kernel.org> (raw)
In-Reply-To: <20240809031827.2373341-1-kuba@kernel.org>
Include the "name" of the context in the comment for traffic
checks. Makes it easier to reason about which context failed
when we loop over 32 contexts (it may matter if we failed in
first vs last, for example).
Reviewed-by: Gal Pressman <gal@nvidia.com>
Reviewed-by: Joe Damato <jdamato@fastly.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
| 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--git a/tools/testing/selftests/drivers/net/hw/rss_ctx.py b/tools/testing/selftests/drivers/net/hw/rss_ctx.py
index 011508ca604b..1da6b214f4fe 100755
--- a/tools/testing/selftests/drivers/net/hw/rss_ctx.py
+++ b/tools/testing/selftests/drivers/net/hw/rss_ctx.py
@@ -90,10 +90,10 @@ from lib.py import ethtool, ip, defer, GenerateTraffic, CmdExitFailure
ksft_ge(directed, 20000, f"traffic on {name}: " + str(cnts))
if params.get('noise'):
ksft_lt(sum(cnts[i] for i in params['noise']), directed / 2,
- "traffic on other queues:" + str(cnts))
+ f"traffic on other queues ({name})':" + str(cnts))
if params.get('empty'):
ksft_eq(sum(cnts[i] for i in params['empty']), 0,
- "traffic on inactive queues: " + str(cnts))
+ f"traffic on inactive queues ({name}): " + str(cnts))
def test_rss_key_indir(cfg):
--
2.46.0
next prev parent reply other threads:[~2024-08-09 3:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 3:18 [PATCH net-next v4 00/12] ethtool: rss: driver tweaks and netlink context dumps Jakub Kicinski
2024-08-09 3:18 ` Jakub Kicinski [this message]
2024-08-09 3:18 ` [PATCH net-next v4 02/12] eth: mvpp2: implement new RSS context API Jakub Kicinski
2024-08-09 14:56 ` Simon Horman
2024-08-09 18:05 ` kernel test robot
2024-08-09 19:47 ` kernel test robot
2024-08-09 3:18 ` [PATCH net-next v4 03/12] eth: mlx5: allow disabling queues when RSS contexts exist Jakub Kicinski
2024-08-09 3:18 ` [PATCH net-next v4 04/12] ethtool: make ethtool_ops::cap_rss_ctx_supported optional Jakub Kicinski
2024-08-09 3:18 ` [PATCH net-next v4 05/12] eth: remove .cap_rss_ctx_supported from updated drivers Jakub Kicinski
2024-08-09 3:18 ` [PATCH net-next v4 06/12] ethtool: rss: don't report key if device doesn't support it Jakub Kicinski
2024-08-09 3:18 ` [PATCH net-next v4 07/12] ethtool: rss: move the device op invocation out of rss_prepare_data() Jakub Kicinski
2024-08-09 3:18 ` [PATCH net-next v4 08/12] ethtool: rss: report info about additional contexts from XArray Jakub Kicinski
2024-08-09 3:18 ` [PATCH net-next v4 09/12] ethtool: rss: support dumping RSS contexts Jakub Kicinski
2024-08-09 3:18 ` [PATCH net-next v4 10/12] ethtool: rss: support skipping contexts during dump Jakub Kicinski
2024-08-09 3:18 ` [PATCH net-next v4 11/12] netlink: specs: decode indirection table as u32 array Jakub Kicinski
2024-08-09 3:18 ` [PATCH net-next v4 12/12] selftests: drv-net: rss_ctx: test dumping RSS contexts Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240809031827.2373341-2-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=ahmed.zaki@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jdamato@fastly.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).