From: Simon Horman <horms@kernel.org>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
donald.hunter@redhat.com
Subject: Re: [PATCH nf v1] netfilter: nfnetlink: Initialise extack before use in ACKs
Date: Fri, 9 Aug 2024 16:33:15 +0100 [thread overview]
Message-ID: <20240809153315.GC1951@kernel.org> (raw)
In-Reply-To: <m25xsaq74k.fsf@gmail.com>
On Fri, Aug 09, 2024 at 12:15:55PM +0100, Donald Hunter wrote:
> Simon Horman <horms@kernel.org> writes:
>
> > On Tue, Aug 06, 2024 at 04:43:24PM +0100, Donald Hunter wrote:
> >> Add missing extack initialisation when ACKing BATCH_BEGIN and BATCH_END.
> >>
> >> Fixes: bf2ac490d28c ("netfilter: nfnetlink: Handle ACK flags for batch messages")
> >> Signed-off-by: Donald Hunter <donald.hunter@gmail.com>
> >
> > Hi Donald,
> >
> > I see two other places that extack is used in nfnetlink_rcv_batch().
> > Is it safe to leave them as-is?
>
> There is a memset at the start of the main while loop that zeroes extack
> for those two cases.
Thanks Donald,
I missed that.
I was wondering if it might be best to clear extack at the beginning of
the function. But if the loop needs to clear it on each iteration, then
I think your solution is good.
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2024-08-09 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-06 15:43 [PATCH nf v1] netfilter: nfnetlink: Initialise extack before use in ACKs Donald Hunter
2024-08-09 9:02 ` Simon Horman
2024-08-09 11:15 ` Donald Hunter
2024-08-09 15:33 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240809153315.GC1951@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=donald.hunter@redhat.com \
--cc=edumazet@google.com \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).