From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <socketcan@hartkopp.net>
Cc: <davem@davemloft.net>, <david.hunter.linux@gmail.com>,
<edumazet@google.com>, <javier.carrasco.cruz@gmail.com>,
<kuba@kernel.org>, <linux-can@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <mkl@pengutronix.de>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<skhan@linuxfoundation.org>, <kuniyu@amazon.com>
Subject: Re: [PATCH 1/1] Net: bcm.c: Remove Subtree Instead of Entry
Date: Fri, 9 Aug 2024 13:22:49 -0700 [thread overview]
Message-ID: <20240809202249.16183-1-kuniyu@amazon.com> (raw)
In-Reply-To: <2bf44b8d-b286-4a94-8e1d-6c4e736a1d07@hartkopp.net>
From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Fri, 9 Aug 2024 11:57:41 +0200
> Hello David,
>
> many thanks for the patch and the description.
>
> Btw. the data structures of the elements inside that bcm proc dir should
> have been removed at that point, so that the can-bcm dir should be empty.
>
> I'm not sure what happens to the open sockets that are (later) removed
> in bcm_release() when we use remove_proc_subtree() as suggested.
> Removing this warning probably does not heal the root cause of the issue.
I posted a patch to fix bcm's proc entry leak few weeks ago, and this might
be related.
https://lore.kernel.org/netdev/20240722192842.37421-1-kuniyu@amazon.com/
Oliver, could you take this patch to can tree ?
next prev parent reply other threads:[~2024-08-09 20:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-08 20:26 [PATCH 1/1] Net: bcm.c: Remove Subtree Instead of Entry David Hunter
2024-08-09 9:57 ` Oliver Hartkopp
2024-08-09 16:21 ` David Hunter
2024-08-09 20:22 ` Kuniyuki Iwashima [this message]
2024-08-09 20:28 ` Kuniyuki Iwashima
2024-08-30 10:56 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240809202249.16183-1-kuniyu@amazon.com \
--to=kuniyu@amazon.com \
--cc=davem@davemloft.net \
--cc=david.hunter.linux@gmail.com \
--cc=edumazet@google.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=skhan@linuxfoundation.org \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).