netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties
@ 2024-08-02 20:57 Frank Li
  2024-08-09 12:03 ` Ioana Ciornei
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Frank Li @ 2024-08-02 20:57 UTC (permalink / raw)
  To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ioana Ciornei,
	open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

Replace additionalProperties with unevaluatedProperties because it have
allOf: $ref: ethernet-controller.yaml#.

Fixed below CHECK_DTBS warnings:
arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb:
   fsl-mc@80c000000: dpmacs:ethernet@11: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/misc/fsl,qoriq-mc.yaml#

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
index a1b71b35319e7..6538e0ce90b28 100644
--- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
@@ -41,7 +41,7 @@ properties:
 required:
   - reg
 
-additionalProperties: false
+unevaluatedProperties: false
 
 examples:
   - |
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties
  2024-08-02 20:57 [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties Frank Li
@ 2024-08-09 12:03 ` Ioana Ciornei
  2024-08-10  3:48 ` Jakub Kicinski
  2024-08-10 11:43 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Ioana Ciornei @ 2024-08-09 12:03 UTC (permalink / raw)
  To: Frank Li
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On Fri, Aug 02, 2024 at 04:57:33PM -0400, Frank Li wrote:
> Replace additionalProperties with unevaluatedProperties because it have
> allOf: $ref: ethernet-controller.yaml#.
> 
> Fixed below CHECK_DTBS warnings:
> arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb:
>    fsl-mc@80c000000: dpmacs:ethernet@11: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/misc/fsl,qoriq-mc.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>

Thanks!

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties
  2024-08-02 20:57 [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties Frank Li
  2024-08-09 12:03 ` Ioana Ciornei
@ 2024-08-10  3:48 ` Jakub Kicinski
  2024-08-10 11:43 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2024-08-10  3:48 UTC (permalink / raw)
  To: Frank Li
  Cc: David S. Miller, Eric Dumazet, Paolo Abeni, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Ioana Ciornei,
	open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list, imx

On Fri,  2 Aug 2024 16:57:33 -0400 Frank Li wrote:
> Replace additionalProperties with unevaluatedProperties because it have
> allOf: $ref: ethernet-controller.yaml#.
> 
> Fixed below CHECK_DTBS warnings:
> arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb:
>    fsl-mc@80c000000: dpmacs:ethernet@11: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/misc/fsl,qoriq-mc.yaml#


We need a review tag from device tree maintainers, please repost once
you get one (or if you don't hear back by the end of next week).
I presume they may be on vacation given the time of the year.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties
  2024-08-02 20:57 [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties Frank Li
  2024-08-09 12:03 ` Ioana Ciornei
  2024-08-10  3:48 ` Jakub Kicinski
@ 2024-08-10 11:43 ` Krzysztof Kozlowski
  2 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-10 11:43 UTC (permalink / raw)
  To: Frank Li, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Ioana Ciornei, open list:NETWORKING DRIVERS,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	open list
  Cc: imx

On 02/08/2024 22:57, Frank Li wrote:
> Replace additionalProperties with unevaluatedProperties because it have
> allOf: $ref: ethernet-controller.yaml#.
> 
> Fixed below CHECK_DTBS warnings:
> arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb:
>    fsl-mc@80c000000: dpmacs:ethernet@11: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/misc/fsl,qoriq-mc.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> index a1b71b35319e7..6538e0ce90b28 100644
> --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> @@ -41,7 +41,7 @@ properties:
>  required:
>    - reg
>  
> -additionalProperties: false
> +unevaluatedProperties: false

Then drop unneeded properties (xxx: true).

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-08-10 11:43 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-02 20:57 [PATCH 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties Frank Li
2024-08-09 12:03 ` Ioana Ciornei
2024-08-10  3:48 ` Jakub Kicinski
2024-08-10 11:43 ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).