From: Jakub Kicinski <kuba@kernel.org>
To: Petr Machata <petrm@nvidia.com>
Cc: Mohsin Bashir <mohsin.bashr@gmail.com>, <netdev@vger.kernel.org>,
<shuah@kernel.org>, <davem@davemloft.net>, <edumazet@google.com>,
<pabeni@redhat.com>, <willemb@google.com>, <dw@davidwei.uk>,
<przemyslaw.kitszel@intel.com>, <linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH net-next v2] selftests: net: py: support verbose printing, display executed commands
Date: Fri, 9 Aug 2024 21:03:42 -0700 [thread overview]
Message-ID: <20240809210342.244413c1@kernel.org> (raw)
In-Reply-To: <87jzgpna14.fsf@nvidia.com>
On Fri, 9 Aug 2024 14:36:17 +0200 Petr Machata wrote:
> > + env_level = env.get('VERBOSE')
> > + set_verbosity(env_level)
> > +
>
> Actually, the ksft_setup() here was merged last week, and I think that
> would be a better place to put this stuff. It already handles
> DISRUPTIVE, it should IMHO handle VERBOSE as well.
I was wondering about that too, FWIW, but the counter argument is that
VERBOSE has little to do with ksft. It doesn't even include the #
prefix on the list it outputs by itself (unlike ksft_pr() which does).
Maybe we do as you suggest but rename verbose() to ksft_dbg() and
make it act more like ksft_pr()?
next prev parent reply other threads:[~2024-08-10 4:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 0:24 [PATCH net-next v2] selftests: net: py: support verbose printing, display executed commands Mohsin Bashir
2024-08-09 12:36 ` Petr Machata
2024-08-10 4:03 ` Jakub Kicinski [this message]
2024-08-12 10:03 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240809210342.244413c1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=mohsin.bashr@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).