From: kernel test robot <lkp@intel.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev, netdev@vger.kernel.org,
Oleksij Rempel <o.rempel@pengutronix.de>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 3/3] net: phy: dp83tg720: Add cable testing support
Date: Sat, 10 Aug 2024 03:57:35 +0800 [thread overview]
Message-ID: <202408100348.U6S1jP0z-lkp@intel.com> (raw)
In-Reply-To: <20240809072440.3477125-3-o.rempel@pengutronix.de>
Hi Oleksij,
kernel test robot noticed the following build errors:
[auto build test ERROR on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Oleksij-Rempel/phy-Add-Open-Alliance-helpers-for-the-PHY-framework/20240809-172119
base: net-next/main
patch link: https://lore.kernel.org/r/20240809072440.3477125-3-o.rempel%40pengutronix.de
patch subject: [PATCH net-next v3 3/3] net: phy: dp83tg720: Add cable testing support
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20240810/202408100348.U6S1jP0z-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240810/202408100348.U6S1jP0z-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408100348.U6S1jP0z-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/net/phy/open_alliance_helpers.c: In function 'oa_1000bt1_get_ethtool_cable_result_code':
>> drivers/net/phy/open_alliance_helpers.c:34:25: error: implicit declaration of function 'FIELD_GET' [-Wimplicit-function-declaration]
34 | u8 tdr_status = FIELD_GET(OA_1000BT1_HDD_TDR_STATUS_MASK, reg_value);
| ^~~~~~~~~
vim +/FIELD_GET +34 drivers/net/phy/open_alliance_helpers.c
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 21
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 22 /**
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 23 * oa_1000bt1_get_ethtool_cable_result_code - Convert TDR status to ethtool
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 24 * result code
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 25 * @reg_value: Value read from the TDR register
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 26 *
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 27 * This function takes a register value from the HDD.TDR register and converts
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 28 * the TDR status to the corresponding ethtool cable test result code.
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 29 *
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 30 * Return: The appropriate ethtool result code based on the TDR status
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 31 */
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 32 int oa_1000bt1_get_ethtool_cable_result_code(u16 reg_value)
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 33 {
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 @34 u8 tdr_status = FIELD_GET(OA_1000BT1_HDD_TDR_STATUS_MASK, reg_value);
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 35 u8 dist_val = FIELD_GET(OA_1000BT1_HDD_TDR_DISTANCE_MASK, reg_value);
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 36
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 37 switch (tdr_status) {
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 38 case OA_1000BT1_HDD_TDR_STATUS_CABLE_OK:
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 39 return ETHTOOL_A_CABLE_RESULT_CODE_OK;
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 40 case OA_1000BT1_HDD_TDR_STATUS_OPEN:
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 41 return ETHTOOL_A_CABLE_RESULT_CODE_OPEN;
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 42 case OA_1000BT1_HDD_TDR_STATUS_SHORT:
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 43 return ETHTOOL_A_CABLE_RESULT_CODE_SAME_SHORT;
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 44 case OA_1000BT1_HDD_TDR_STATUS_NOISE:
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 45 return ETHTOOL_A_CABLE_RESULT_CODE_NOISE;
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 46 default:
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 47 if (dist_val == OA_1000BT1_HDD_TDR_DISTANCE_RESOLUTION_NOT_POSSIBLE)
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 48 return ETHTOOL_A_CABLE_RESULT_CODE_RESOLUTION_NOT_POSSIBLE;
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 49 return ETHTOOL_A_CABLE_RESULT_CODE_UNSPEC;
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 50 }
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 51 }
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 52 EXPORT_SYMBOL_GPL(oa_1000bt1_get_ethtool_cable_result_code);
f4eee3aa678aeb0 Oleksij Rempel 2024-08-09 53
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-08-09 19:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 7:24 [PATCH net-next v3 1/3] ethtool: Add new result codes for TDR diagnostics Oleksij Rempel
2024-08-09 7:24 ` [PATCH net-next v3 2/3] phy: Add Open Alliance helpers for the PHY framework Oleksij Rempel
2024-08-09 7:24 ` [PATCH net-next v3 3/3] net: phy: dp83tg720: Add cable testing support Oleksij Rempel
2024-08-09 17:55 ` kernel test robot
2024-08-09 19:57 ` kernel test robot [this message]
2024-08-10 6:16 ` Oleksij Rempel
2024-08-10 17:22 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202408100348.U6S1jP0z-lkp@intel.com \
--to=lkp@intel.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).