From: Kory Maincent <kory.maincent@bootlin.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, donald.hunter@gmail.com, ahmed.zaki@intel.com,
sudheer.mogilappagari@intel.com
Subject: Re: [PATCH net 2/2] ethtool: rss: echo the context number back
Date: Sun, 11 Aug 2024 10:27:45 +0200 [thread overview]
Message-ID: <20240811102745.542f6d02@kmaincent-XPS-13-7390> (raw)
In-Reply-To: <20240724234249.2621109-3-kuba@kernel.org>
On Wed, 24 Jul 2024 16:42:49 -0700
Jakub Kicinski <kuba@kernel.org> wrote:
> The response to a GET request in Netlink should fully identify
> the queried object. RSS_GET accepts context id as an input,
> so it must echo that attribute back to the response.
>
> After (assuming context 1 has been created):
>
> $ ./cli.py --spec netlink/specs/ethtool.yaml \
> --do rss-get \
> --json '{"header": {"dev-index": 2}, "context": 1}'
> {'context': 1,
> 'header': {'dev-index': 2, 'dev-name': 'eth0'},
> [...]
Reviewed-by: Kory Maincent <kory.maincent@bootlin.com>
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2024-08-11 8:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 23:42 [PATCH net 0/2] ethtool: rss: small fixes to spec and GET Jakub Kicinski
2024-07-24 23:42 ` [PATCH net 1/2] netlink: specs: correct the spec of ethtool Jakub Kicinski
2024-08-11 8:25 ` Kory Maincent
2024-07-24 23:42 ` [PATCH net 2/2] ethtool: rss: echo the context number back Jakub Kicinski
2024-08-11 8:27 ` Kory Maincent [this message]
2024-07-25 11:30 ` [PATCH net 0/2] ethtool: rss: small fixes to spec and GET Paolo Abeni
2024-07-25 17:36 ` Joe Damato
2024-07-25 23:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240811102745.542f6d02@kmaincent-XPS-13-7390 \
--to=kory.maincent@bootlin.com \
--cc=ahmed.zaki@intel.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sudheer.mogilappagari@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).