From: Simon Horman <horms@kernel.org>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: kuba@kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, idosch@nvidia.com, amcohen@nvidia.com,
gnault@redhat.com, dongml2@chinatelecom.cn, b.galvani@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: vxlan: remove duplicated initialization in vxlan_xmit
Date: Sun, 11 Aug 2024 14:58:35 +0100 [thread overview]
Message-ID: <20240811135835.GK1951@kernel.org> (raw)
In-Reply-To: <20240810020632.367019-1-dongml2@chinatelecom.cn>
On Sat, Aug 10, 2024 at 10:06:32AM +0800, Menglong Dong wrote:
> The variable "did_rsc" is initialized twice, which is unnecessary. Just
> remove one of them.
>
> Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
Thanks, I have verified that did_rsc is initialised to false,
else where in this function, before it is otherwise used.
And, as the function may return before then, it does seem
reasonable to defer initialisation until then.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-08-11 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-10 2:06 [PATCH net-next] net: vxlan: remove duplicated initialization in vxlan_xmit Menglong Dong
2024-08-11 13:58 ` Simon Horman [this message]
2024-08-12 12:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240811135835.GK1951@kernel.org \
--to=horms@kernel.org \
--cc=amcohen@nvidia.com \
--cc=b.galvani@gmail.com \
--cc=davem@davemloft.net \
--cc=dongml2@chinatelecom.cn \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).