From: Christoph Hellwig <hch@lst.de>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Anna Schumaker <Anna.Schumaker@Netapp.com>,
Trond Myklebust <trondmy@kernel.org>,
linux-nfs@vger.kernel.org, Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Maxim Mikityanskiy <maxtram95@gmail.com>,
Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Networking <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy
Date: Mon, 12 Aug 2024 11:02:15 +0200 [thread overview]
Message-ID: <20240812090215.GA5497@lst.de> (raw)
In-Reply-To: <8683155c-79ad-4090-9aff-fc8d765b096b@gmail.com>
On Tue, Aug 06, 2024 at 01:07:47PM +0300, Tariq Toukan wrote:
> Adding Maxim Mikityanskiy, he might have some insights.
I think the important part to find out is if the in-kernel TLS API
has a limitation to PAGE_SIZE buffer segments, or not. If it does
we need to disable large folios for the in-kernel consumers of the
API, which is easy (but annoying) for NFS that trigger this, but quite
painful for NVMe. Or the API is supposed to handle it and just this
one offload gets it wrong, in which case we need to fix it.
next prev parent reply other threads:[~2024-08-12 9:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 10:40 [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy Tariq Toukan
2024-08-05 11:43 ` Sagi Grimberg
2024-08-06 4:43 ` Tariq Toukan
2024-08-06 8:09 ` Sagi Grimberg
2024-08-06 10:07 ` Tariq Toukan
2024-08-11 11:21 ` Tariq Toukan
2024-08-11 18:33 ` Sagi Grimberg
2024-08-12 13:15 ` Tariq Toukan
2024-08-12 13:23 ` Christoph Hellwig
2024-08-12 9:02 ` Christoph Hellwig [this message]
2024-08-12 9:13 ` Sagi Grimberg
2024-08-12 11:06 ` Christoph Hellwig
2024-08-12 23:23 ` Jakub Kicinski
2024-11-14 19:05 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812090215.GA5497@lst.de \
--to=hch@lst.de \
--cc=Anna.Schumaker@Netapp.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=maxtram95@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sagi@grimberg.me \
--cc=tariqt@nvidia.com \
--cc=trondmy@kernel.org \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).