From: Simon Horman <horms@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, vburru@marvell.com, sedara@marvell.com,
srasheed@marvell.com, sburla@marvell.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: octeon_ep_vf: use ethtool_sprintf/puts
Date: Mon, 12 Aug 2024 13:42:24 +0100 [thread overview]
Message-ID: <20240812124224.GA7679@kernel.org> (raw)
In-Reply-To: <20240809044738.4347-1-rosenp@gmail.com>
On Thu, Aug 08, 2024 at 09:47:27PM -0700, Rosen Penev wrote:
> Simplifies the function and avoids manual pointer manipulation.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Thanks,
The code changes look good to me and my local testing shows that it compiles.
So, from that point of view:
Reviewed-by: Simon Horman <horms@kernel.org>
But I do have a few points about process, which I hope you will
give due consideration:
1. It would be good if the patch description was a bit more verbose.
And indicated how you found this problem (by inspection?)
and how it was tested (compile tested only?).
This helps set expectations for reviewers of this patch,
both now and in the future.
2. You have posed a number of similar patches.
To aid review it would be best to group these, say in batches of
no more than 10.
F.e. Point 1, above, doesn't just apply to this patch.
3. Please do review the Networking subsystem process document
https://docs.kernel.org/process/maintainer-netdev.html
...
next prev parent reply other threads:[~2024-08-12 12:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 4:47 [PATCH net-next] net: octeon_ep_vf: use ethtool_sprintf/puts Rosen Penev
2024-08-12 12:42 ` Simon Horman [this message]
2024-08-12 17:04 ` Rosen Penev
2024-08-12 21:03 ` Andrew Lunn
2024-08-13 7:54 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812124224.GA7679@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=vburru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).