From: Christoph Hellwig <hch@lst.de>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Anna Schumaker <Anna.Schumaker@Netapp.com>,
Trond Myklebust <trondmy@kernel.org>,
linux-nfs@vger.kernel.org, Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>,
Maxim Mikityanskiy <maxtram95@gmail.com>,
David Howells <dhowells@redhat.com>,
Sabrina Dubroca <sd@queasysnail.net>,
Mina Almasry <almasrymina@google.com>,
Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Networking <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
drort@nvidia.com
Subject: Re: [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy
Date: Mon, 12 Aug 2024 15:23:54 +0200 [thread overview]
Message-ID: <20240812132354.GA23655@lst.de> (raw)
In-Reply-To: <c1096b57-a03f-4fa2-b61f-7418f2304618@gmail.com>
On Mon, Aug 12, 2024 at 04:15:35PM +0300, Tariq Toukan wrote:
>> Can you explain where in your test is NFS used? Is the nginx server runs
>> on an NFS mount?
>
> I checked with the team.
> The requested file, as well as the wrk and nginx apps, all reside on an NFS
> mount.
So maybe I misunderstood the workload. You aren't using the NFS over
TLS, but your are webserving using sendfile with the TLS offload,
with the data coming from a NFS share that isn't using TLS?
In that case NFS really is just the trigger here and you'd see the
exact same behavior when serving from another large folios enabled
file system like XFS, or probably also when serving from anonymous
memory. This very clearly points to a debug in the hardware TLS
offload.
next prev parent reply other threads:[~2024-08-12 13:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 10:40 [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy Tariq Toukan
2024-08-05 11:43 ` Sagi Grimberg
2024-08-06 4:43 ` Tariq Toukan
2024-08-06 8:09 ` Sagi Grimberg
2024-08-06 10:07 ` Tariq Toukan
2024-08-11 11:21 ` Tariq Toukan
2024-08-11 18:33 ` Sagi Grimberg
2024-08-12 13:15 ` Tariq Toukan
2024-08-12 13:23 ` Christoph Hellwig [this message]
2024-08-12 9:02 ` Christoph Hellwig
2024-08-12 9:13 ` Sagi Grimberg
2024-08-12 11:06 ` Christoph Hellwig
2024-08-12 23:23 ` Jakub Kicinski
2024-11-14 19:05 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812132354.GA23655@lst.de \
--to=hch@lst.de \
--cc=Anna.Schumaker@Netapp.com \
--cc=almasrymina@google.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=drort@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=maxtram95@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sagi@grimberg.me \
--cc=sd@queasysnail.net \
--cc=tariqt@nvidia.com \
--cc=trondmy@kernel.org \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).