From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28CFE175D59; Mon, 12 Aug 2024 23:23:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723505012; cv=none; b=kH7awCgoP9RbSv0DghAsVjBBtScoK8BohJ0DeP+kuNb5ji218tIMDXkaa5YYFWfFqWgi2Gs4nSXNIdOB0ViygWEI0vcJQxw+5xCst+FexKB8sFIiYWmnDCWVxSig67LPVcNJG6qYMbNQ2SKWC0jde4midqszMkSMxzKfVaY2VFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723505012; c=relaxed/simple; bh=5ewRKoMVxsN885I2VkloOsrGqHKI0p6ygfp3g2u4lgk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hvvd25sd1gPCZgkmwFRgKXe3sS1PloADJhKI2wEsIeYk03s8bGDS1cB7/3znqho68jL6Rk1QZzoagXS9efGAvvoL8gpZcdtwneZ2zwsDJcH4qTxVffVBmYrXwQkGTb0LdhcdT+dg2rq10Ue8dVu2lkxqkHCPyBAs2zqMCxPTB8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FTBCMR3/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FTBCMR3/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0AB8CC4AF0D; Mon, 12 Aug 2024 23:23:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723505011; bh=5ewRKoMVxsN885I2VkloOsrGqHKI0p6ygfp3g2u4lgk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FTBCMR3/vR522Q6cV8aElPlbxUBn6rVU9tYgFjwL/Y+g9raT7fYQVGNrcNPf1Eh7/ 7zT0eB9YS+bMCnDNVCHGzEm3PCWG/xW3cxHV7oCo0rLw/dEfLgLL5qK2T6mpMCdudr zKK0Ct7NtqpxT1V0IbDyatIHUn2yrpfWmrhOkCLo2uIxayDvbwr7CzWi131Bq80GFj iu1/rQJsAFk5KVETKERe7uyp5HRjuyyMAZ1/uUvG3Kw3M4j33gBUFLJNQPz1fq5uJy TAIb1GBByREciANG+Z8wD/YvFHQOz6Nqw13ymfL1uJ16sv/Y8mpaiR48Atqrc2Jf4M Rx6AtzGWs280w== Date: Mon, 12 Aug 2024 16:23:29 -0700 From: Jakub Kicinski To: Sagi Grimberg Cc: Christoph Hellwig , Tariq Toukan , Anna Schumaker , Trond Myklebust , linux-nfs@vger.kernel.org, Boris Pismenny , John Fastabend , Maxim Mikityanskiy , Saeed Mahameed , Gal Pressman , Networking , Paolo Abeni , Eric Dumazet , "David S. Miller" , Linux Kernel Mailing List , Leon Romanovsky , Tariq Toukan Subject: Re: [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy Message-ID: <20240812162329.7224eb26@kernel.org> In-Reply-To: <06a66824-cc2e-4f6d-8776-c2bd415c06f9@grimberg.me> References: <77fb3db5-7a59-4879-b9c2-d3408fcf67e8@grimberg.me> <4f42fac4-2a4e-426a-be86-1f4bb79987b4@gmail.com> <3e08421f-91ac-4bd1-9886-3d5ecf9afa04@grimberg.me> <8683155c-79ad-4090-9aff-fc8d765b096b@gmail.com> <20240812090215.GA5497@lst.de> <06a66824-cc2e-4f6d-8776-c2bd415c06f9@grimberg.me> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 12 Aug 2024 12:13:51 +0300 Sagi Grimberg wrote: > On 12/08/2024 12:02, Christoph Hellwig wrote: > > On Tue, Aug 06, 2024 at 01:07:47PM +0300, Tariq Toukan wrote: > >> Adding Maxim Mikityanskiy, he might have some insights. > > I think the important part to find out is if the in-kernel TLS API > > has a limitation to PAGE_SIZE buffer segments, or not. > > I don't see why it should. Also note that sw tls does not suffer from > this. Maybe Jakub can add more light here in case something was missed? I don't recall anything special. For SW crypto the splice is kinda moot, because we encrypt and use the ciphertext so the plaintext pages are likely to be freed before sendmsg() returns. For offload we wait until the data is acked (not just sent) so any potential race window is significantly longer. There's also the use of pfrag in the offload path. Dunno..