From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"Jay Vosburgh" <jv@jvosburgh.net>,
Andy Gospodarek <andy@greyhouse.net>, <netdev@vger.kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Hangbin Liu <liuhangbin@gmail.com>,
Jianbo Liu <jianbol@nvidia.com>
Subject: Re: [PATCH net V3 1/3] bonding: implement xdo_dev_state_free and call it after deletion
Date: Mon, 12 Aug 2024 17:48:34 -0700 [thread overview]
Message-ID: <20240812174834.4bcba98d@kernel.org> (raw)
In-Reply-To: <20240805050357.2004888-2-tariqt@nvidia.com>
On Mon, 5 Aug 2024 08:03:55 +0300 Tariq Toukan wrote:
> +static void bond_ipsec_free_sa(struct xfrm_state *xs)
> +{
> + struct net_device *bond_dev = xs->xso.dev;
> + struct net_device *real_dev;
> + struct bonding *bond;
> + struct slave *slave;
> +
> + if (!bond_dev)
> + return;
can xs->xso.dev be NULL during the dev_free_state callback?
> + rcu_read_lock();
> + bond = netdev_priv(bond_dev);
> + slave = rcu_dereference(bond->curr_active_slave);
> + real_dev = slave ? slave->dev : NULL;
> + rcu_read_unlock();
What's holding onto real_dev once you drop the rcu lock here?
next prev parent reply other threads:[~2024-08-13 0:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 5:03 [PATCH net V3 0/3] Fixes for IPsec over bonding Tariq Toukan
2024-08-05 5:03 ` [PATCH net V3 1/3] bonding: implement xdo_dev_state_free and call it after deletion Tariq Toukan
2024-08-06 8:45 ` Hangbin Liu
2024-08-06 9:09 ` Jianbo Liu
2024-08-07 10:11 ` Hangbin Liu
2024-08-13 0:48 ` Jakub Kicinski [this message]
2024-08-13 2:58 ` Jianbo Liu
2024-08-13 14:14 ` Jakub Kicinski
2024-08-14 2:03 ` Jianbo Liu
2024-08-14 3:11 ` Hangbin Liu
2024-08-15 1:23 ` Jianbo Liu
2024-08-15 3:34 ` Hangbin Liu
2024-08-15 3:57 ` Jianbo Liu
2024-08-05 5:03 ` [PATCH net V3 2/3] bonding: extract the use of real_device into local variable Tariq Toukan
2024-08-07 10:13 ` Hangbin Liu
2024-08-05 5:03 ` [PATCH net V3 3/3] bonding: change ipsec_lock from spin lock to mutex Tariq Toukan
2024-08-08 9:34 ` Hangbin Liu
2024-08-08 10:05 ` Jianbo Liu
2024-08-09 2:31 ` Hangbin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812174834.4bcba98d@kernel.org \
--to=kuba@kernel.org \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jianbol@nvidia.com \
--cc=jv@jvosburgh.net \
--cc=leonro@nvidia.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).