From: Sean Anderson <sean.anderson@linux.dev>
To: Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Michal Simek <michal.simek@amd.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Paolo Abeni <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
linux-arm-kernel@lists.infradead.org,
Jakub Kicinski <kuba@kernel.org>,
Ariane Keller <ariane.keller@tik.ee.ethz.ch>,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH net-next 3/4] net: xilinx: axienet: Don't print if we go into promiscuous mode
Date: Mon, 12 Aug 2024 16:04:36 -0400 [thread overview]
Message-ID: <20240812200437.3581990-4-sean.anderson@linux.dev> (raw)
In-Reply-To: <20240812200437.3581990-1-sean.anderson@linux.dev>
A message about being in promiscuous mode is printed every time each
additional multicast address beyond four is added. Suppress this message
like is done in other drivers. And don't set IFF_PROMISC in ndev->flags;
contrary to the comment we don't have to inform the net subsystem.
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
index 1bcabb016ca9..9bcad515f156 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c
@@ -439,15 +439,9 @@ static void axienet_set_multicast_list(struct net_device *ndev)
if (ndev->flags & (IFF_ALLMULTI | IFF_PROMISC) ||
netdev_mc_count(ndev) > XAE_MULTICAST_CAM_TABLE_NUM) {
- /* We must make the kernel realize we had to move into
- * promiscuous mode. If it was a promiscuous mode request
- * the flag is already set. If not we set it.
- */
- ndev->flags |= IFF_PROMISC;
reg = axienet_ior(lp, XAE_FMI_OFFSET);
reg |= XAE_FMI_PM_MASK;
axienet_iow(lp, XAE_FMI_OFFSET, reg);
- dev_info(&ndev->dev, "Promiscuous mode enabled.\n");
} else if (!netdev_mc_empty(ndev)) {
struct netdev_hw_addr *ha;
@@ -481,7 +475,6 @@ static void axienet_set_multicast_list(struct net_device *ndev)
reg &= ~XAE_FMI_PM_MASK;
axienet_iow(lp, XAE_FMI_OFFSET, reg);
- dev_info(&ndev->dev, "Promiscuous mode disabled.\n");
}
for (; i < XAE_MULTICAST_CAM_TABLE_NUM; i++) {
--
2.35.1.1320.gc452695387.dirty
next prev parent reply other threads:[~2024-08-12 20:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 20:04 [PATCH net-next 0/4] net: xilinx: axienet: Multicast fixes and improvements Sean Anderson
2024-08-12 20:04 ` [PATCH net-next 1/4] net: xilinx: axienet: Always disable promiscuous mode Sean Anderson
2024-08-15 14:58 ` Simon Horman
2024-08-15 15:14 ` Sean Anderson
2024-08-15 15:17 ` Simon Horman
2024-08-12 20:04 ` [PATCH net-next 2/4] net: xilinx: axienet: Fix dangling multicast addresses Sean Anderson
2024-08-15 15:01 ` Simon Horman
2024-08-12 20:04 ` Sean Anderson [this message]
2024-08-15 14:59 ` [PATCH net-next 3/4] net: xilinx: axienet: Don't print if we go into promiscuous mode Simon Horman
2024-08-15 15:15 ` Sean Anderson
2024-08-12 20:04 ` [PATCH net-next 4/4] net: xilinx: axienet: Support IFF_ALLMULTI Sean Anderson
2024-08-15 15:02 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240812200437.3581990-4-sean.anderson@linux.dev \
--to=sean.anderson@linux.dev \
--cc=andrew@lunn.ch \
--cc=ariane.keller@tik.ee.ethz.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=radhey.shyam.pandey@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).