netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kuniyuki Iwashima <kuniyu@amazon.com>
To: <jain.abhinav177@gmail.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>,
	<javier.carrasco.cruz@gmail.com>, <kuba@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>,
	<netdev@vger.kernel.org>, <pabeni@redhat.com>, <shuah@kernel.org>,
	<skhan@linuxfoundation.org>, <kuniyu@amazon.com>
Subject: Re: [PATCH net v2] selftest: af_unix: Fix kselftest compilation warnings
Date: Mon, 12 Aug 2024 13:13:06 -0700	[thread overview]
Message-ID: <20240812201306.70769-1-kuniyu@amazon.com> (raw)
In-Reply-To: <20240812191122.1092806-1-jain.abhinav177@gmail.com>

From: Abhinav Jain <jain.abhinav177@gmail.com>
Date: Tue, 13 Aug 2024 00:41:22 +0530
> Change the parameter expected_buf from (const void *) to (const char *)
> in the function __recvpair() as per the feedback in v1.
> Add Fixes tag as per feedback in v1.
> 
> This change fixes the below warnings during test compilation:
> 
> ```
> In file included from msg_oob.c:14:
> msg_oob.c: In function ‘__recvpair’:
> 
> ../../kselftest_harness.h:106:40: warning: format ‘%s’ expects argument
> of type ‘char *’,but argument 6 has type ‘const void *’ [-Wformat=]
> 
> ../../kselftest_harness.h:101:17: note: in expansion of macro ‘__TH_LOG’
> msg_oob.c:235:17: note: in expansion of macro ‘TH_LOG’
> 
> ../../kselftest_harness.h:106:40: warning: format ‘%s’ expects argument
> of type ‘char *’,but argument 6 has type ‘const void *’ [-Wformat=]
> 
> ../../kselftest_harness.h:101:17: note: in expansion of macro ‘__TH_LOG’
> msg_oob.c:259:25: note: in expansion of macro ‘TH_LOG’
> ```
> 
> v1:
> lore.kernel.org/netdev/20240810134037.669765-1-jain.abhinav177@gmail.com
> 
> Fixes: d098d77232c3 ("selftest: af_unix: Add msg_oob.c.")
> Signed-off-by: Abhinav Jain <jain.abhinav177@gmail.com>

No need to respin, but a minor comment below for the future patches.

Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com>

> ---

You can put changelog between revisions after "---" so that it will
disappear during merge.

And, it would be easy to jump to v1 if it has https:// .

Here's a nice example:

https://docs.kernel.org/process/maintainer-netdev.html#changes-requested

Thanks!

  reply	other threads:[~2024-08-12 20:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-12 19:11 [PATCH net v2] selftest: af_unix: Fix kselftest compilation warnings Abhinav Jain
2024-08-12 20:13 ` Kuniyuki Iwashima [this message]
2024-08-14  1:21 ` Jakub Kicinski
2024-08-14  8:10   ` Abhinav Jain
2024-08-14 14:43     ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240812201306.70769-1-kuniyu@amazon.com \
    --to=kuniyu@amazon.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=jain.abhinav177@gmail.com \
    --cc=javier.carrasco.cruz@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).