From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D040419EEA4 for ; Tue, 13 Aug 2024 14:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723561109; cv=none; b=MlPWlWDjCQhJLq4BI59neiudG8z/hYBCxhbN9r9vsJDZqlsgbdOH02J5MWuEMCD+mXWFeT7p/QZYqOnN1PVwv4e0lJJ8O/MhjUV4UgSLVme0ZrTJX3EVVS3siVinkzZoYgEud+D2ECx9YSC4d8gAMhZJP6LShIuCOjHhHRRZg1s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723561109; c=relaxed/simple; bh=evrNuqFMPeQnnqxD9Q7pnyiac9OQpyHKNWla5vGz1mA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=PIo8bKDQ5LCehwIY4OGI5V170TvKzeT4D+tBqA6E8onyZxHNosjzCpT2/WtWrl7K7FhRdzXq3eI9XvsxURIsfrxHa99pjv2W0j5dNuj0SE5lf/2GkC+HneAzYPIavIAKNNYJTpfmxBcOkjoaKZvjKiQXLFM/59bfjEHpqOrhUD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Tj0OA9/I; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Tj0OA9/I" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E614EC4AF09; Tue, 13 Aug 2024 14:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723561109; bh=evrNuqFMPeQnnqxD9Q7pnyiac9OQpyHKNWla5vGz1mA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Tj0OA9/IMrtMlbf8CrPGAeaa1RwUnk/eL+OnxtL90PJP/S6cL4TS9NFAKiCFuBA5F 7FJtPhkxDW0oHVBLEg2RHs1WVUSqk9PYxnkVKkU7aaImqCaLM5zWYCiPaAOojPoZ+v aKnARtMmFz6WJSh+aQOLzlF/fxNR3BtHm6tvE6mjm4qwljuqHPZLDrrXWyhfo3fqVW ikJmyTX4NfpgVazPsCG+kAv5LO5E0FgV7ZzSKhFeO2ZcUh3J5G/oGZbugf0A2E7qwU XZptiFcfDyptYf5J4P9aUHYK2RfZuUsl1cr7ckAZEigW5uyHKtpdzKyfm/TpX19Yji VCElrtmJ9kM+A== Date: Tue, 13 Aug 2024 07:58:28 -0700 From: Jakub Kicinski To: Paolo Abeni Cc: Jiri Pirko , Donald Hunter , netdev@vger.kernel.org, Madhu Chittim , Sridhar Samudrala , Simon Horman , John Fastabend , Sunil Kovvuri Goutham , Jamal Hadi Salim Subject: Re: [PATCH v3 02/12] netlink: spec: add shaper YAML spec Message-ID: <20240813075828.4ead43d4@kernel.org> In-Reply-To: References: <13747e9505c47d88c22a12a372ea94755c6ba3b2.1722357745.git.pabeni@redhat.com> <8819eae1-8491-40f6-a819-8b27793f9eff@redhat.com> <74a14ded-298f-4ccc-aa15-54070d3a35b7@redhat.com> <20240812082544.277b594d@kernel.org> <20240812104221.22bc0cca@kernel.org> <20240813071214.5724e81b@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 13 Aug 2024 16:47:34 +0200 Paolo Abeni wrote: > >> Creating a node inside a tree, isn't it? Therefore subtree. > > > > All nodes are inside the tree. > > > >> But it could be unified to node_set() as Paolo suggested. That would > >> work for any node, including leaf, tree, non-existent internal node. > > > > A "set" operation which creates a node. > > Here the outcome is unclear to me. My understanding is that group() does > not fit Jiri nor Donald and and node_set() or subtree_set() do not fit > Jakub. > > Did I misread something? As a trade-off, what about, group_set()? "set" is not a sensible verb for creating something. "group" in the original was the verb. Why are both saying "set" and not "create"? What am I missing?