From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
eperezma@redhat.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Cc: virtualization@lists.linux.dev, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, venkat.x.venkatsubra@oracle.com,
gia-khanh.nguyen@oracle.com
Subject: [PATCH net-next v7 0/4] virtio-net: synchronize op/admin state
Date: Wed, 14 Aug 2024 13:22:24 +0800 [thread overview]
Message-ID: <20240814052228.4654-1-jasowang@redhat.com> (raw)
Hi All:
This series tries to synchronize the operstate with the admin state
which allows the lower virtio-net to propagate the link status to the
upper devices like macvlan.
This is done by toggling carrier during ndo_open/stop while doing
other necessary serialization about the carrier settings during probe.
While at it, also fix a race between probe and ndo_set_features as we
didn't initalize the guest offload setting under rtnl lock.
Changes since V6:
- Add fix tag
Changes since V5:
- Fix sevreal typos
- Include a new patch to synchronize probe with ndo_set_features
Changes since V4:
- do not update settings during ndo_open()
- do not try to canel config noticiation during probe() as core make
sure the config notificaiton won't be triggered before probe is
done.
- Tweak sevreal comments.
Changes since V3:
- when driver tries to enable config interrupt, check pending
interrupt and execute the nofitication change callback if necessary
- do not unconditonally trigger the config space read
- do not set LINK_UP flag in ndo_open/close but depends on the
notification change
- disable config change notification until ndo_open()
- read the link status under the rtnl_lock() to prevent a race with
ndo_open()
Changes since V2:
- introduce config_driver_disabled and helpers
- schedule config change work unconditionally
Thanks
Jason Wang (4):
virtio: rename virtio_config_enabled to virtio_config_core_enabled
virtio: allow driver to disable the configure change notification
virtio-net: synchronize operstate with admin state on up/down
virtio-net: synchronize probe with ndo_set_features
drivers/net/virtio_net.c | 78 +++++++++++++++++++++++++---------------
drivers/virtio/virtio.c | 59 +++++++++++++++++++++++-------
include/linux/virtio.h | 11 ++++--
3 files changed, 105 insertions(+), 43 deletions(-)
--
2.31.1
next reply other threads:[~2024-08-14 5:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 5:22 Jason Wang [this message]
2024-08-14 5:22 ` [PATCH net-next v7 1/4] virtio: rename virtio_config_enabled to virtio_config_core_enabled Jason Wang
2024-08-14 5:22 ` [PATCH net-next v7 2/4] virtio: allow driver to disable the configure change notification Jason Wang
2024-08-14 5:22 ` [PATCH net-next v7 3/4] virtio-net: synchronize operstate with admin state on up/down Jason Wang
2024-08-14 5:22 ` [PATCH net-next v7 4/4] virtio-net: synchronize probe with ndo_set_features Jason Wang
2024-08-16 2:30 ` [PATCH net-next v7 0/4] virtio-net: synchronize op/admin state patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240814052228.4654-1-jasowang@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eperezma@redhat.com \
--cc=gia-khanh.nguyen@oracle.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=venkat.x.venkatsubra@oracle.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).