From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E2BA9A35; Thu, 15 Aug 2024 00:20:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723681249; cv=none; b=GtFHbRv7L3a2L/p16Y9sZyFx2h8KoG372ne46QI754YP4U3ztOm1wkW9MlIqjhXdyQz82sV5HChbV1CfC28WBL9tRQpbKVDWciAkbTRUO7aiDtlxky/ff5u4KQpgv/VRuM2oIoUrpNk9p6EP9Aj+tcg0Mu8gZjToRN3bnuJAT2Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723681249; c=relaxed/simple; bh=FSrgGRb2+2F//PvIuCsVOMjuXhKEz50wuCkJVSwdb+I=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k3+WJjEzZ7yOVMgf2uxa/WTeS79Ho5arksLldlLXzsdaoACQI6QH1iAgAVP+HHNKqi5Tikqi5NCj0YcopX5mPi3sTapt3HfEp0CWgtjBvwnOYT5SV13cDST///yNkmaJ9LfTq0URswsyYNVHn6v9NaaZ93O6VrI2cHhgFe4WK/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rDPO14qK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rDPO14qK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 54EF3C32786; Thu, 15 Aug 2024 00:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1723681248; bh=FSrgGRb2+2F//PvIuCsVOMjuXhKEz50wuCkJVSwdb+I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rDPO14qKjJ1wnJ5ZxvYB9oMTm0/dws2WGAOGyl+hbv6KhS7THK4MgXl5q5cfVfsnq zgV9IHzFBohsEXiQzywZv65pzVGd9Qb+xnraM5bvU64DylyBf7QpsVihlIwMEttQ3G hzFh+IRclmhDON97ZiVB1HbgZKQSFjjFv58beXMeaJEM0ZnT9yFaK5ERXdF6zAHZaG 9z8P6BwK//xXongNDIzPn/rySWH5hk75m+HFbk6WeOIqRsOTBwBl2bv4AKKEHmyKy3 n3TduAjS4Thzq+grfjIa6nb6jrMEE6gF06O+/Hw606DJ/UlKnUS5tPJ5yeblHKnGZg 6Y/Aozow4NgSw== Date: Wed, 14 Aug 2024 17:20:46 -0700 From: Jakub Kicinski To: Joe Damato Cc: Shay Drori , netdev@vger.kernel.org, Daniel Borkmann , "David S. Miller" , Eric Dumazet , Harshitha Ramamurthy , "moderated list:INTEL ETHERNET DRIVERS" , Jeroen de Borst , Jiri Pirko , Leon Romanovsky , open list , "open list:MELLANOX MLX4 core VPI driver" , Lorenzo Bianconi , Paolo Abeni , Praveen Kaligineedi , Przemek Kitszel , Saeed Mahameed , Sebastian Andrzej Siewior , Shailend Chand , Tariq Toukan , Tony Nguyen , Willem de Bruijn , Yishai Hadas , Ziwei Xiao Subject: Re: [RFC net-next 0/6] Cleanup IRQ affinity checks in several drivers Message-ID: <20240814172046.7753a62c@kernel.org> In-Reply-To: References: <20240812145633.52911-1-jdamato@fastly.com> <20240813171710.599d3f01@kernel.org> <20240814080915.005cb9ac@kernel.org> <701eb84c-8d26-4945-8af3-55a70e05b09c@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 14 Aug 2024 19:01:40 +0100 Joe Damato wrote: > If it is, then the only option is to have the drivers pass in their > IRQ affinity masks, as Stanislav suggested, to avoid adding that > call to the hot path. > > If not, then the IRQ from napi_struct can be used and the affinity > mask can be generated on every napi poll. i40e/gve/iavf would need > calls to netif_napi_set_irq to set the IRQ mapping, which seems to > be straightforward. It's a bit sad to have the generic solution blocked. cpu_rmap_update() is exported. Maybe we can call it from our notifier? rmap lives in struct net_device