From: Jakub Kicinski <kuba@kernel.org>
To: Abhinav Jain <jain.abhinav177@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com,
javier.carrasco.cruz@gmail.com, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, shuah@kernel.org, skhan@linuxfoundation.org
Subject: Re: [PATCH net v6 0/2] Enhance network interface feature testing
Date: Thu, 15 Aug 2024 08:50:12 -0700 [thread overview]
Message-ID: <20240815085012.01edb574@kernel.org> (raw)
In-Reply-To: <20240815110442.1389625-1-jain.abhinav177@gmail.com>
On Thu, 15 Aug 2024 16:34:42 +0530 Abhinav Jain wrote:
> > > One more:
> > >
> > > tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev: set IP address"
> > >
> > > I think the SKIP -> XFAIL conversion should be a separate patch (for
> > > total of 3 patches in the series).
> >
> > P.S. and please change the subject to [PATCH net-next], it's a net-next
> > change, not a net fix.
>
> I have sent v7 now with net-next instead of net:
> https://lore.kernel.org/all/20240815105924.1389290-1-jain.abhinav177@gmail.com
>
> For set IP address part, I have added logic to XFAIL if veth pair was created
> and to SKIP if that's not the case in third patch of the series as directed above.
>
> Right now, there is no logic to set IP address in the script for normal interfaces
> either and it is a TODO as well. I will focus on it next after this one is applied.
Minor note, please keep your guidance on frequency of reposting in mind:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
--
pv-bot: 24h
prev parent reply other threads:[~2024-08-15 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 19:15 [PATCH net v6 0/2] Enhance network interface feature testing Abhinav Jain
2024-08-14 19:15 ` [PATCH net v6 1/2] selftests: net: Create veth pair for testing in networkless kernel Abhinav Jain
2024-08-14 19:15 ` [PATCH net v6 2/2] selftests: net: Add on/off checks for non-fixed features of interface Abhinav Jain
2024-08-15 0:56 ` [PATCH net v6 0/2] Enhance network interface feature testing Jakub Kicinski
2024-08-15 0:57 ` Jakub Kicinski
2024-08-15 11:04 ` Abhinav Jain
2024-08-15 15:50 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815085012.01edb574@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jain.abhinav177@gmail.com \
--cc=javier.carrasco.cruz@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).