From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: Abhash jha <abhashkumarjha123@gmail.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah@kernel.org, netdev@vger.kernel.org, liuhangbin@gmail.com
Subject: Re: [PATCH] selftests/net/pmtu.sh: Fix typo in error message
Date: Thu, 15 Aug 2024 17:38:18 -0700 [thread overview]
Message-ID: <20240815173818.12780279@kernel.org> (raw)
In-Reply-To: <20240815174508.GO632411@kernel.org>
On Thu, 15 Aug 2024 18:45:08 +0100 Simon Horman wrote:
> On Thu, Aug 15, 2024 at 10:37:19PM +0530, Abhash jha wrote:
> > > I agree with the correctness of this change.
> > > And I verified that with this patch applied,
> > > coedspell only flags false positives in this file.
> > >
> > > Reviewed-by: Simon Horman <horms@kernel.org>
> >
> > Hi Simon,
> > Thanks for the review, Should I still send the patch again with the
> > fixes tag and the target repo for the patch as suggested by
> > liuhangbin@gmail.com. Or is it fine for now.
>
> Sorry for sending my response before I noticed Hangbin's -
> I didn't mean to send conflicting information.
>
> TBH, I'm not entirely sure this is a fix, for which my
> rule of thumb is that it resolves a user-visible bug.
+1, same feeling here, I'll apply as is.
next prev parent reply other threads:[~2024-08-16 0:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 17:31 [PATCH] selftests/net/pmtu.sh: Fix typo in error message Abhash Jha
2024-08-15 7:35 ` Hangbin Liu
2024-08-15 12:53 ` Simon Horman
2024-08-15 17:07 ` Abhash jha
2024-08-15 17:45 ` Simon Horman
2024-08-16 0:38 ` Jakub Kicinski [this message]
2024-08-16 3:55 ` Hangbin Liu
2024-08-16 2:01 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815173818.12780279@kernel.org \
--to=kuba@kernel.org \
--cc=abhashkumarjha123@gmail.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).