From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, David Ahern <dsahern@kernel.org>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v1 net-next 0/2] net: Clean up af_ops->{get_link_af_size,fill_link_af}().
Date: Thu, 15 Aug 2024 18:36:51 -0700 [thread overview]
Message-ID: <20240815183651.7692863f@kernel.org> (raw)
In-Reply-To: <20240815211137.62280-1-kuniyu@amazon.com>
On Thu, 15 Aug 2024 14:11:35 -0700 Kuniyuki Iwashima wrote:
> Since commit 5fa85a09390c ("net: core: rcu-ify rtnl af_ops"),
> af_ops->{get_link_af_size,fill_link_af}() are called under RCU.
>
> Patch 1 makes the context clear and patch 2 removes unnecessary
> rcu_read_lock().
Tests violently disagree.
https://netdev.bots.linux.dev/contest.html?branch=net-next-2024-08-16--00-00&pw-n=0&pass=0
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-16 1:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 21:11 [PATCH v1 net-next 0/2] net: Clean up af_ops->{get_link_af_size,fill_link_af}() Kuniyuki Iwashima
2024-08-15 21:11 ` [PATCH v1 net-next 1/2] ipv4: Use RCU helper in inet_get_link_af_size() and inet_fill_link_af() Kuniyuki Iwashima
2024-08-15 21:11 ` [PATCH v1 net-next 2/2] net: bridge: Remove rcu_read_lock() in br_get_link_af_size_filtered() Kuniyuki Iwashima
2024-08-16 1:36 ` Jakub Kicinski [this message]
2024-08-16 2:39 ` [PATCH v1 net-next 0/2] net: Clean up af_ops->{get_link_af_size,fill_link_af}() Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815183651.7692863f@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).