From: Jakub Kicinski <kuba@kernel.org>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: Jeremy Kerr <jk@codeconstruct.com.au>,
Matt Johnston <matt@codeconstruct.com.au>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Kuniyuki Iwashima <kuni1840@gmail.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH v1 net] mctp: Use __mctp_dev_get() in mctp_fill_link_af().
Date: Thu, 15 Aug 2024 18:39:46 -0700 [thread overview]
Message-ID: <20240815183946.342e9952@kernel.org> (raw)
In-Reply-To: <20240815204254.49813-1-kuniyu@amazon.com>
On Thu, 15 Aug 2024 13:42:54 -0700 Kuniyuki Iwashima wrote:
> Since commit 5fa85a09390c ("net: core: rcu-ify rtnl af_ops"),
> af_ops->fill_link_af() is called under RCU.
>
> mctp_fill_link_af() calls mctp_dev_get_rtnl() that uses
> rtnl_dereference(), so lockdep should complain about it.
>
> Let's use __mctp_dev_get() instead.
And this is what crashes kunit tests, I reckon.
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-16 1:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 20:42 [PATCH v1 net] mctp: Use __mctp_dev_get() in mctp_fill_link_af() Kuniyuki Iwashima
2024-08-16 1:39 ` Jakub Kicinski [this message]
2024-08-16 3:08 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815183946.342e9952@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jk@codeconstruct.com.au \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=matt@codeconstruct.com.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).