From: Jakub Kicinski <kuba@kernel.org>
To: Justin Lai <justinlai0215@realtek.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<andrew@lunn.ch>, <jiri@resnulli.us>, <horms@kernel.org>,
<rkannoth@marvell.com>, <jdamato@fastly.com>,
<pkshih@realtek.com>, <larry.chiu@realtek.com>
Subject: Re: [PATCH net-next v27 07/13] rtase: Implement a function to receive packets
Date: Thu, 15 Aug 2024 18:54:52 -0700 [thread overview]
Message-ID: <20240815185452.3df3eea9@kernel.org> (raw)
In-Reply-To: <20240812063539.575865-8-justinlai0215@realtek.com>
On Mon, 12 Aug 2024 14:35:33 +0800 Justin Lai wrote:
> + if (!delta && workdone)
> + netdev_info(dev, "no Rx buffer allocated\n");
> +
> + ring->dirty_idx += delta;
> +
> + if ((ring->dirty_idx + RTASE_NUM_DESC) == ring->cur_idx)
> + netdev_emerg(dev, "Rx buffers exhausted\n");
Memory allocation failures happen, we shouldn't risk spamming the logs.
I mean these two messages and the one in rtase_alloc_rx_data_buf(),
the should be removed.
There is a alloc_fail statistic defined in include/net/netdev_queues.h
that's the correct way to report buffer allocation failures.
And you should have a periodic service task / work which checks for
buffers being exhausted, and if they are schedule NAPI so that it tries
to allocate.
next prev parent reply other threads:[~2024-08-16 1:54 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 6:35 [PATCH net-next v27 00/13] Add Realtek automotive PCIe driver Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 01/13] rtase: Add support for a pci table in this module Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 02/13] rtase: Implement the .ndo_open function Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 03/13] rtase: Implement the rtase_down function Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 05/13] rtase: Implement hardware configuration function Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 07/13] rtase: Implement a function to receive packets Justin Lai
2024-08-16 1:54 ` Jakub Kicinski [this message]
2024-08-16 7:50 ` Justin Lai
2024-08-20 5:13 ` Larry Chiu
2024-08-20 14:41 ` Jakub Kicinski
2024-08-21 9:02 ` Larry Chiu
2024-08-21 22:21 ` Jakub Kicinski
2024-08-12 6:35 ` [PATCH net-next v27 08/13] rtase: Implement net_device_ops Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 10/13] rtase: Implement ethtool function Justin Lai
2024-08-16 1:46 ` Jakub Kicinski
2024-08-16 6:44 ` Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2024-08-12 6:35 ` [PATCH net-next v27 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815185452.3df3eea9@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=jiri@resnulli.us \
--cc=justinlai0215@realtek.com \
--cc=larry.chiu@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pkshih@realtek.com \
--cc=rkannoth@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).