From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org, aleksander.lobakin@intel.com,
przemyslaw.kitszel@intel.com, joshua.a.hay@intel.com,
michal.kubiak@intel.com,
nex.sw.ncis.osdt.itp.upstreaming@intel.com
Subject: Re: [PATCH net-next 0/9][pull request] idpf: XDP chapter II: convert Tx completion to libeth
Date: Thu, 15 Aug 2024 19:18:59 -0700 [thread overview]
Message-ID: <20240815191859.13a2dfa8@kernel.org> (raw)
In-Reply-To: <20240814173309.4166149-1-anthony.l.nguyen@intel.com>
On Wed, 14 Aug 2024 10:32:57 -0700 Tony Nguyen wrote:
> Alexander Lobakin says:
>
> XDP for idpf is currently 5 chapters:
> * convert Rx to libeth;
> * convert Tx completion and stats to libeth (this);
> * generic XDP and XSk code changes;
> * actual XDP for idpf via libeth_xdp;
> * XSk for idpf (^).
>
> Part II does the following:
> * introduces generic libeth per-queue stats infra;
> * adds generic libeth Tx completion routines;
> * converts idpf to use generic libeth Tx comp routines;
> * fixes Tx queue timeouts and robustifies Tx completion in general;
> * fixes Tx event/descriptor flushes (writebacks);
> * fully switches idpf per-queue stats to libeth.
>
> Most idpf patches again remove more lines than adds.
> The perf difference is not visible by eye in common scenarios, but
> the stats are now more complete and reliable, and also survive
> ifups-ifdowns.
I'm tossing this.
Eric and Paolo are mostly AFK this month, I'm struggling to keep up
and instead of helping review stuff you pile patches. That's not right.
--
pw-bot: defer
next prev parent reply other threads:[~2024-08-16 2:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 17:32 [PATCH net-next 0/9][pull request] idpf: XDP chapter II: convert Tx completion to libeth Tony Nguyen
2024-08-14 17:32 ` [PATCH net-next 1/9] unroll: add generic loop unroll helpers Tony Nguyen
2024-08-14 17:32 ` [PATCH net-next 2/9] libeth: add common queue stats Tony Nguyen
2024-08-14 17:33 ` [PATCH net-next 3/9] libie: add Tx buffer completion helpers Tony Nguyen
2024-08-14 17:33 ` [PATCH net-next 4/9] idpf: convert to libie Tx buffer completion Tony Nguyen
2024-08-14 17:33 ` [PATCH net-next 5/9] netdevice: add netdev_tx_reset_subqueue() shorthand Tony Nguyen
2024-08-14 17:33 ` [PATCH net-next 6/9] idpf: refactor Tx completion routines Tony Nguyen
2024-08-14 17:33 ` [PATCH net-next 7/9] idpf: fix netdev Tx queue stop/wake Tony Nguyen
2024-08-14 17:33 ` [PATCH net-next 8/9] idpf: enable WB_ON_ITR Tony Nguyen
2024-08-14 17:33 ` [PATCH net-next 9/9] idpf: switch to libeth generic statistics Tony Nguyen
2024-08-16 2:18 ` Jakub Kicinski [this message]
2024-08-16 20:31 ` [PATCH net-next 0/9][pull request] idpf: XDP chapter II: convert Tx completion to libeth Tony Nguyen
2024-08-16 20:40 ` Jakub Kicinski
2024-08-16 20:45 ` Tony Nguyen
2024-08-19 11:58 ` Alexander Lobakin
2024-08-19 15:22 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240815191859.13a2dfa8@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joshua.a.hay@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).