From: Simon Horman <horms@kernel.org>
To: Zhang Changzhong <zhangchangzhong@huawei.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] net: remove redundant check in skb_shift()
Date: Fri, 16 Aug 2024 11:49:41 +0100 [thread overview]
Message-ID: <20240816104941.GQ632411@kernel.org> (raw)
In-Reply-To: <1723730983-22912-1-git-send-email-zhangchangzhong@huawei.com>
On Thu, Aug 15, 2024 at 10:09:42PM +0800, Zhang Changzhong wrote:
> The check for '!to' is redundant here, since skb_can_coalesce() already
> contains this check.
It would be nice to mention here how this was found (e.g. found by
inspection, flagged by private static analysis tool, ...) and how it was
tested (e.g. compile tested only).
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
In any case, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-08-16 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-15 14:09 [PATCH net-next] net: remove redundant check in skb_shift() Zhang Changzhong
2024-08-16 10:49 ` Simon Horman [this message]
2024-08-20 1:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816104941.GQ632411@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhangchangzhong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).