From: Jakub Kicinski <kuba@kernel.org>
To: Divya Koppera <divya.koppera@microchip.com>
Cc: <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<arun.ramadoss@microchip.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v2 1/2] net: phy: Add phy library support to check supported list when autoneg is enabled
Date: Fri, 16 Aug 2024 11:18:10 -0700 [thread overview]
Message-ID: <20240816111810.64355472@kernel.org> (raw)
In-Reply-To: <20240813181515.863208-2-divya.koppera@microchip.com>
On Tue, 13 Aug 2024 23:45:14 +0530 Divya Koppera wrote:
> - if (autoneg == AUTONEG_ENABLE && linkmode_empty(advertising))
> + if (autoneg == AUTONEG_ENABLE &&
> + (linkmode_empty(advertising) ||
> + !(linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
> + phydev->supported))))
nti: no need to wrap the linkmode_test_bit() in brackets:
!linkmode_test_bit(ETHTOOL_LINK_MODE_Autoneg_BIT,
phydev->supported)))
otherwise LGTM.
Please try to put links to previous versions into the cover letter.
--
pw-bot: cr
next prev parent reply other threads:[~2024-08-16 18:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-13 18:15 [PATCH net-next v2 0/2] Adds support for lan887x phy Divya Koppera
2024-08-13 18:15 ` [PATCH net-next v2 1/2] net: phy: Add phy library support to check supported list when autoneg is enabled Divya Koppera
2024-08-16 18:18 ` Jakub Kicinski [this message]
2024-08-13 18:15 ` [PATCH net-next v2 2/2] net: phy: microchip_t1: Adds support for lan887x phy Divya Koppera
2024-08-16 20:56 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816111810.64355472@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=arun.ramadoss@microchip.com \
--cc=davem@davemloft.net \
--cc=divya.koppera@microchip.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).