netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: jitendra.vegiraju@broadcom.com
Cc: netdev@vger.kernel.org, alexandre.torgue@foss.st.com,
	joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com,
	pabeni@redhat.com, mcoquelin.stm32@gmail.com,
	bcm-kernel-feedback-list@broadcom.com, richardcochran@gmail.com,
	ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org,
	john.fastabend@gmail.com, fancer.lancer@gmail.com,
	rmk+kernel@armlinux.org.uk, ahalaney@redhat.com,
	xiaolei.wang@windriver.com, rohan.g.thomas@intel.com,
	Jianheng.Zhang@synopsys.com, leong.ching.swee@intel.com,
	linux-kernel@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org, bpf@vger.kernel.org,
	andrew@lunn.ch, linux@armlinux.org.uk, horms@kernel.org,
	florian.fainelli@broadcom.com
Subject: Re: [net-next v4 4/5] net: stmmac: Add PCI driver support for BCM8958x
Date: Fri, 16 Aug 2024 11:27:41 -0700	[thread overview]
Message-ID: <20240816112741.33a3405f@kernel.org> (raw)
In-Reply-To: <20240814221818.2612484-5-jitendra.vegiraju@broadcom.com>

On Wed, 14 Aug 2024 15:18:17 -0700 jitendra.vegiraju@broadcom.com wrote:
> +	pci_restore_state(pdev);
> +	pci_set_power_state(pdev, PCI_D0);
> +
> +	ret = pci_enable_device(pdev);
> +	if (ret)
> +		return ret;
> +
> +	pci_set_master(pdev);

pci_restore_state() doesn't restore master and enable?

  reply	other threads:[~2024-08-16 18:27 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-14 22:18 [net-next v4 0/5] net: stmmac: Add PCI driver support for BCM8958x jitendra.vegiraju
2024-08-14 22:18 ` [net-next v4 1/5] net: stmmac: Add HDMA mapping for dw25gmac support jitendra.vegiraju
2024-08-15 23:30   ` Abhishek Chauhan (ABC)
2024-08-20 23:10     ` Jitendra Vegiraju
2024-08-20 23:12       ` Abhishek Chauhan (ABC)
2024-08-14 22:18 ` [net-next v4 2/5] net: stmmac: Add basic dw25gmac support to stmmac core jitendra.vegiraju
2024-08-22 17:16   ` Amit Singh Tomar
2024-08-26 17:41     ` Jitendra Vegiraju
2024-08-14 22:18 ` [net-next v4 3/5] net: stmmac: Integrate dw25gmac into stmmac hwif handling jitendra.vegiraju
2024-08-23 13:48   ` Serge Semin
2024-08-26 18:53     ` Jitendra Vegiraju
2024-08-29 10:52       ` Serge Semin
2024-08-30 23:35         ` Jitendra Vegiraju
2024-08-14 22:18 ` [net-next v4 4/5] net: stmmac: Add PCI driver support for BCM8958x jitendra.vegiraju
2024-08-16 18:27   ` Jakub Kicinski [this message]
2024-08-20 23:16     ` Jitendra Vegiraju
2024-08-22 16:35   ` Amit Singh Tomar
2024-08-26 17:30     ` Jitendra Vegiraju
2024-08-27 20:32       ` Amit Singh Tomar
2024-08-14 22:18 ` [net-next v4 5/5] net: stmmac: Add BCM8958x driver to build system jitendra.vegiraju
2024-08-16 18:46 ` [net-next v4 0/5] net: stmmac: Add PCI driver support for BCM8958x Serge Semin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240816112741.33a3405f@kernel.org \
    --to=kuba@kernel.org \
    --cc=Jianheng.Zhang@synopsys.com \
    --cc=ahalaney@redhat.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andrew@lunn.ch \
    --cc=ast@kernel.org \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=fancer.lancer@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=jitendra.vegiraju@broadcom.com \
    --cc=joabreu@synopsys.com \
    --cc=john.fastabend@gmail.com \
    --cc=leong.ching.swee@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux@armlinux.org.uk \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=rohan.g.thomas@intel.com \
    --cc=xiaolei.wang@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).