From: Simon Horman <horms@kernel.org>
To: Zhang Zekun <zhangzekun11@huawei.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, mkl@pengutronix.de, netdev@vger.kernel.org
Subject: Re: [PATCH] net: ethernet: ibm: Simpify code with for_each_child_of_node()
Date: Fri, 16 Aug 2024 17:24:38 +0100 [thread overview]
Message-ID: <20240816162438.GV632411@kernel.org> (raw)
In-Reply-To: <20240816015837.109627-1-zhangzekun11@huawei.com>
On Fri, Aug 16, 2024 at 09:58:37AM +0800, Zhang Zekun wrote:
> for_each_child_of_node can help to iterate through the device_node,
> and we don't need to use while loop. No functional change with this
> conversion.
>
> Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com>
I don't think there is a need to respin for this,
but the patch should be explicitly targeted at net-next
Subject: [PATCH net-next] ...
Otherwise, this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2024-08-16 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-16 1:58 [PATCH] net: ethernet: ibm: Simpify code with for_each_child_of_node() Zhang Zekun
2024-08-16 16:24 ` Simon Horman [this message]
2024-08-20 13:21 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240816162438.GV632411@kernel.org \
--to=horms@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=zhangzekun11@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).