* [PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync()
@ 2024-08-16 10:04 Yue Haibing
2024-08-16 11:10 ` Matthieu Baerts
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yue Haibing @ 2024-08-16 10:04 UTC (permalink / raw)
To: matttbe, martineau, geliang, davem, edumazet, kuba, pabeni
Cc: netdev, mptcp, linux-kernel, yuehaibing
Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization")
removed the implementation but leave declaration.
Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
net/mptcp/protocol.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
index 60c6b073d65f..08387140a646 100644
--- a/net/mptcp/protocol.h
+++ b/net/mptcp/protocol.h
@@ -1154,7 +1154,6 @@ static inline void mptcp_pm_close_subflow(struct mptcp_sock *msk)
spin_unlock_bh(&msk->pm.lock);
}
-void mptcp_sockopt_sync(struct mptcp_sock *msk, struct sock *ssk);
void mptcp_sockopt_sync_locked(struct mptcp_sock *msk, struct sock *ssk);
static inline struct mptcp_ext *mptcp_get_ext(const struct sk_buff *skb)
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync()
2024-08-16 10:04 [PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync() Yue Haibing
@ 2024-08-16 11:10 ` Matthieu Baerts
2024-08-16 16:41 ` Simon Horman
2024-08-20 1:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Matthieu Baerts @ 2024-08-16 11:10 UTC (permalink / raw)
To: Yue Haibing, martineau, geliang, davem, edumazet, kuba, pabeni
Cc: netdev, mptcp, linux-kernel
Hi Yue Haibing,
On 16/08/2024 12:04, Yue Haibing wrote:
> Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization")
> removed the implementation but leave declaration.
Good catch, it looks good to me:
Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
@Netdev maintainers: it can be applied in net-next, or in -net if you
prefer.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync()
2024-08-16 10:04 [PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync() Yue Haibing
2024-08-16 11:10 ` Matthieu Baerts
@ 2024-08-16 16:41 ` Simon Horman
2024-08-20 1:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2024-08-16 16:41 UTC (permalink / raw)
To: Yue Haibing
Cc: matttbe, martineau, geliang, davem, edumazet, kuba, pabeni,
netdev, mptcp, linux-kernel
On Fri, Aug 16, 2024 at 06:04:04PM +0800, Yue Haibing wrote:
> Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization")
> removed the implementation but leave declaration.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync()
2024-08-16 10:04 [PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync() Yue Haibing
2024-08-16 11:10 ` Matthieu Baerts
2024-08-16 16:41 ` Simon Horman
@ 2024-08-20 1:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-08-20 1:00 UTC (permalink / raw)
To: Yue Haibing
Cc: matttbe, martineau, geliang, davem, edumazet, kuba, pabeni,
netdev, mptcp, linux-kernel
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 16 Aug 2024 18:04:04 +0800 you wrote:
> Commit a1ab24e5fc4a ("mptcp: consolidate sockopt synchronization")
> removed the implementation but leave declaration.
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> net/mptcp/protocol.h | 1 -
> 1 file changed, 1 deletion(-)
Here is the summary with links:
- [-next] mptcp: Remove unused declaration mptcp_sockopt_sync()
https://git.kernel.org/netdev/net-next/c/af3dc0ad3167
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-20 1:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-16 10:04 [PATCH -next] mptcp: Remove unused declaration mptcp_sockopt_sync() Yue Haibing
2024-08-16 11:10 ` Matthieu Baerts
2024-08-16 16:41 ` Simon Horman
2024-08-20 1:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).